Hi there,
I started coding for GSoC yesterday, since I need Monday off for a college exam. I pushed the changes that I did to my repo [1], and they are available for you to try on my demo server [2] (There are some routines and triggers in the sakila db, but you'll have to add your own events). Well, first of all I'd appreciate any feedback from you guys regarding what I did. Which was: adding tabs for routines, triggers, events; moving there the functionality that was already available; getting export and drop options to work properly. However I have a problem with the "Drop" option that doesn't redirect the user back to where he came from after deleting the requested object. I tried adding a "goto" variable to $urlquery, but by the time that the user is taken to sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any clues?
Thanks, Rouslan
[1]: http://repo.or.cz/w/phpmyadmin/roccivic.git [2]: http://demo.phpmyadmin.net/gsoc-rouslan/
2011/5/22 Rouslan Placella rouslan@placella.com:
Hi there,
I started coding for GSoC yesterday, since I need Monday off for a college exam. I pushed the changes that I did to my repo [1], and they are available for you to try on my demo server [2] (There are some routines and triggers in the sakila db, but you'll have to add your own events). Well, first of all I'd appreciate any feedback from you guys regarding what I did. Which was: adding tabs for routines, triggers, events; moving there the functionality that was already available; getting export and drop options to work properly. However I have a problem with the "Drop" option that doesn't redirect the user back to where he came from after deleting the requested object. I tried adding a "goto" variable to $urlquery, but by the time that the user is taken to sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any clues?
Thanks, Rouslan
I think you should join Time and Event columns in Triggers tab, they are usually thought of as one thing.
Please don't show Events, Triggers and Routines tabs for Drizzle (check PMA_DRIZZLE constant) - none of these is currently supported.
On Sun, 2011-05-22 at 21:33 +0200, Piotr Przybylski wrote:
2011/5/22 Rouslan Placella rouslan@placella.com:
Hi there,
I started coding for GSoC yesterday, since I need Monday off for a college exam. I pushed the changes that I did to my repo [1], and they are available for you to try on my demo server [2] (There are some routines and triggers in the sakila db, but you'll have to add your own events). Well, first of all I'd appreciate any feedback from you guys regarding what I did. Which was: adding tabs for routines, triggers, events; moving there the functionality that was already available; getting export and drop options to work properly. However I have a problem with the "Drop" option that doesn't redirect the user back to where he came from after deleting the requested object. I tried adding a "goto" variable to $urlquery, but by the time that the user is taken to sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any clues?
Thanks, Rouslan
I think you should join Time and Event columns in Triggers tab, they are usually thought of as one thing.
Please don't show Events, Triggers and Routines tabs for Drizzle (check PMA_DRIZZLE constant) - none of these is currently supported.
Hey Piotr,
thanks for your comments. I'll make sure to hide these features for Drizzle users. I take it that the PMA_DRIZZLE constant is already available as of 3.4.0.
As far as joining the Time and Event columns, I didn't code that list myself, so I just left it as it was. Besides I think that I'll be displaying these parameters separately in the event editor, so to me it makes sense to keep them separate also in the list of events.
Rouslan
2011/5/23 Rouslan Placella rouslan@placella.com:
On Sun, 2011-05-22 at 21:33 +0200, Piotr Przybylski wrote:
2011/5/22 Rouslan Placella rouslan@placella.com:
Hi there,
I started coding for GSoC yesterday, since I need Monday off for a college exam. I pushed the changes that I did to my repo [1], and they are available for you to try on my demo server [2] (There are some routines and triggers in the sakila db, but you'll have to add your own events). Well, first of all I'd appreciate any feedback from you guys regarding what I did. Which was: adding tabs for routines, triggers, events; moving there the functionality that was already available; getting export and drop options to work properly. However I have a problem with the "Drop" option that doesn't redirect the user back to where he came from after deleting the requested object. I tried adding a "goto" variable to $urlquery, but by the time that the user is taken to sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any clues?
Thanks, Rouslan
I think you should join Time and Event columns in Triggers tab, they are usually thought of as one thing.
Please don't show Events, Triggers and Routines tabs for Drizzle (check PMA_DRIZZLE constant) - none of these is currently supported.
Hey Piotr,
thanks for your comments. I'll make sure to hide these features for Drizzle users. I take it that the PMA_DRIZZLE constant is already available as of 3.4.0.
Yes, it's available.
As far as joining the Time and Event columns, I didn't code that list myself, so I just left it as it was. Besides I think that I'll be displaying these parameters separately in the event editor, so to me it makes sense to keep them separate also in the list of events.
Hi
Dne Sun, 22 May 2011 19:45:24 +0100 Rouslan Placella rouslan@placella.com napsal(a):
I started coding for GSoC yesterday, since I need Monday off for a college exam. I pushed the changes that I did to my repo [1], and they are available for you to try on my demo server [2] (There are some routines and triggers in the sakila db, but you'll have to add your own events). Well, first of all I'd appreciate any feedback from you guys regarding what I did. Which was: adding tabs for routines, triggers, events; moving there the functionality that was already available; getting export and drop options to work properly. However I have a problem with the "Drop" option that doesn't redirect the user back to where he came from after deleting the requested object. I tried adding a "goto" variable to $urlquery, but by the time that the user is taken to sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any clues?
It clearly looks like goto is ignored on sql.php in all cases with confirmation, please file a bug for it.
On Mon, 2011-05-23 at 16:07 +0200, Michal Čihař wrote:
Hi
Dne Sun, 22 May 2011 19:45:24 +0100 Rouslan Placella rouslan@placella.com napsal(a):
I started coding for GSoC yesterday, since I need Monday off for a college exam. I pushed the changes that I did to my repo [1], and they are available for you to try on my demo server [2] (There are some routines and triggers in the sakila db, but you'll have to add your own events). Well, first of all I'd appreciate any feedback from you guys regarding what I did. Which was: adding tabs for routines, triggers, events; moving there the functionality that was already available; getting export and drop options to work properly. However I have a problem with the "Drop" option that doesn't redirect the user back to where he came from after deleting the requested object. I tried adding a "goto" variable to $urlquery, but by the time that the user is taken to sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any clues?
It clearly looks like goto is ignored on sql.php in all cases with confirmation, please file a bug for it.
I'm not sure that this is a bug. When I disable JS and go to browse a table and then click on the "Delete" link next to a row of data, after the confirmation, I am correctly redirected back to browsing the table. Or am I missing something here?
Thanks for your help.
Rouslan
Hi
Dne Mon, 23 May 2011 15:15:49 +0100 Rouslan Placella rouslan@placella.com napsal(a):
I'm not sure that this is a bug. When I disable JS and go to browse a table and then click on the "Delete" link next to a row of data, after the confirmation, I am correctly redirected back to browsing the table. Or am I missing something here?
Indeed it seems to work for browsing, but is broken for example for Truncate table. Reported as bug 3307335.
On Wed, 2011-05-25 at 09:42 +0200, Michal Čihař wrote:
Hi
Dne Mon, 23 May 2011 15:15:49 +0100 Rouslan Placella rouslan@placella.com napsal(a):
I'm not sure that this is a bug. When I disable JS and go to browse a table and then click on the "Delete" link next to a row of data, after the confirmation, I am correctly redirected back to browsing the table. Or am I missing something here?
Indeed it seems to work for browsing, but is broken for example for Truncate table. Reported as bug 3307335.
I managed to fix this for "Drop Routine" functionality, it turns out that I had to add 'db_routines.php' to the $goto_whitelist array in common.inc.php Not sure though if it is the same problem for other functionalities...
Rouslan
-
Michal Čihař -
Piotr Przybylski -
Rouslan Placella