I'm curious about this line:
if (PMA_MYSQL_INT_VERSION >= 20120130)
from libraries/Types.class.php [0], initially added with this commit [1].
That version number doesn't make sense to me. This code snippet deals with Drizzle, which apparently [2] had versions like this at one point, but I'm not sure whether those are production releases or development versions. Regardless, they use more standard version numbers now, such as 7.1. I wonder if this code should be updated.
Any thoughts about this?
0 - https://github.com/phpmyadmin/phpmyadmin/blob/3ada00030f7b1f045422a4e80a1fd8...
1 - d3b1b9f9a2776748dbfe0dd57c77e5ee1b0455fc Support for Drizzle IPV6 column type in Fremont Added SCHEMA function (synonym for DATABASE)
2 - https://www.google.com/search?q=drizzle%2020120130&gws_rd=ssl
Le 2015-05-29 08:09, Isaac Bennetch a écrit :
I'm curious about this line:
if (PMA_MYSQL_INT_VERSION >= 20120130)
from libraries/Types.class.php [0], initially added with this commit [1].
That version number doesn't make sense to me. This code snippet deals with Drizzle, which apparently [2] had versions like this at one point, but I'm not sure whether those are production releases or development versions. Regardless, they use more standard version numbers now, such as 7.1. I wonder if this code should be updated.
Any thoughts about this?
Yes it should be updated, and the wiki too: https://wiki.phpmyadmin.net/pma/Drizzle_for_developers#PMA_MYSQL_INT_VERSION
0 - https://github.com/phpmyadmin/phpmyadmin/blob/3ada00030f7b1f045422a4e80a1fd8...
1 - d3b1b9f9a2776748dbfe0dd57c77e5ee1b0455fc Support for Drizzle IPV6 column type in Fremont Added SCHEMA function (synonym for DATABASE)
2 - https://www.google.com/search?q=drizzle%2020120130&gws_rd=ssl
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On 5/29/15 10:16 AM, marc@infomarc.info wrote:
Le 2015-05-29 08:09, Isaac Bennetch a écrit :
I'm curious about this line:
if (PMA_MYSQL_INT_VERSION >= 20120130)
from libraries/Types.class.php [0], initially added with this commit [1].
That version number doesn't make sense to me. This code snippet deals with Drizzle, which apparently [2] had versions like this at one point, but I'm not sure whether those are production releases or development versions. Regardless, they use more standard version numbers now, such as 7.1. I wonder if this code should be updated.
Any thoughts about this?
Yes it should be updated, and the wiki too: https://wiki.phpmyadmin.net/pma/Drizzle_for_developers#PMA_MYSQL_INT_VERSION
Thanks Marc,
I've created a ticket https://sourceforge.net/p/phpmyadmin/bugs/4932
-
Isaac Bennetch -
marc＠infomarc.info