[Phpmyadmin-devel] warning developers before bug submission
I use a line counts file to allow for some line number translation for submission of bug reports and the script that generates this file is run from the release scripts. If however a developer uses a git revision instead of a release, this file will not have been created. another situation is that the developer generates the file but does changes to the js files which renders the file obsolete. I can detect the obsolescence of the file by checking of modification dates however what do I do if the file does not exist or is obsolete. should I disable error reporting entirely or just display a warning? keeping in mind that a problem with line number translation may result in inaccuracies of grouping similar reports together on the error report server. if I am to entirely disable or display a warning, what should the message say? -- Mohamed Ashraf
On 09/17/2013 10:30 PM, Mohamed Ashraf wrote:
I use a line counts file to allow for some line number translation for submission of bug reports and the script that generates this file is run from the release scripts. If however a developer uses a git revision instead of a release, this file will not have been created. another situation is that the developer generates the file but does changes to the js files which renders the file obsolete.
I can detect the obsolescence of the file by checking of modification dates however what do I do if the file does not exist or is obsolete. should I disable error reporting entirely or just display a warning? keeping in mind that a problem with line number translation may result in inaccuracies of grouping similar reports together on the error report server.
if I am to entirely disable or display a warning, what should the message say?
I would go with disabling the functionality. If someone is using a pma version from git, they are probably techy enough to submit a report by hand. Bye, Rouslan
On Wed, Sep 18, 2013 at 6:37 PM, Rouslan Placella <rouslan@placella.com>wrote:
On 09/17/2013 10:30 PM, Mohamed Ashraf wrote:
I use a line counts file to allow for some line number translation for submission of bug reports and the script that generates this file is run from the release scripts. If however a developer uses a git revision instead of a release, this file will not have been created. another situation is that the developer generates the file but does changes to the js files which renders the file obsolete.
I can detect the obsolescence of the file by checking of modification dates however what do I do if the file does not exist or is obsolete. should I disable error reporting entirely or just display a warning? keeping in mind that a problem with line number translation may result in inaccuracies of grouping similar reports together on the error report server.
if I am to entirely disable or display a warning, what should the message say?
I would go with disabling the functionality. If someone is using a pma version from git, they are probably techy enough to submit a report by hand.
Bye, Rouslan
should I even display a message that an uncaught error has occurred or should I ignore error reporting completely on git checkouts.
------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Mohamed Ashraf
2013/9/18 Mohamed Ashraf <mohamed.ashraf.213@gmail.com>:
On Wed, Sep 18, 2013 at 6:37 PM, Rouslan Placella <rouslan@placella.com> wrote:
On 09/17/2013 10:30 PM, Mohamed Ashraf wrote:
I use a line counts file to allow for some line number translation for submission of bug reports and the script that generates this file is run from the release scripts. If however a developer uses a git revision instead of a release, this file will not have been created. another situation is that the developer generates the file but does changes to the js files which renders the file obsolete.
I can detect the obsolescence of the file by checking of modification dates however what do I do if the file does not exist or is obsolete. should I disable error reporting entirely or just display a warning? keeping in mind that a problem with line number translation may result in inaccuracies of grouping similar reports together on the error report server.
if I am to entirely disable or display a warning, what should the message say?
I would go with disabling the functionality. If someone is using a pma version from git, they are probably techy enough to submit a report by hand.
Bye, Rouslan
should I even display a message that an uncaught error has occurred or should I ignore error reporting completely on git checkouts.
It makes sense to display a message that something went wrong. -- Kind regards, Dieter Adriaenssens
Hi Dne Tue, 17 Sep 2013 23:30:50 +0200 Mohamed Ashraf <mohamed.ashraf.213@gmail.com> napsal(a):
I use a line counts file to allow for some line number translation for submission of bug reports and the script that generates this file is run from the release scripts. If however a developer uses a git revision instead of a release, this file will not have been created. another situation is that the developer generates the file but does changes to the js files which renders the file obsolete.
I can detect the obsolescence of the file by checking of modification dates however what do I do if the file does not exist or is obsolete. should I disable error reporting entirely or just display a warning? keeping in mind that a problem with line number translation may result in inaccuracies of grouping similar reports together on the error report server.
Isn't there option to calculate needed information on the fly when it's not available? I guess it would mean slowdown, but I think that's acceptable for such use. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Wed, Sep 25, 2013 at 10:35 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Tue, 17 Sep 2013 23:30:50 +0200 Mohamed Ashraf <mohamed.ashraf.213@gmail.com> napsal(a):
I use a line counts file to allow for some line number translation for submission of bug reports and the script that generates this file is run from the release scripts. If however a developer uses a git revision instead of a release, this file will not have been created. another situation is that the developer generates the file but does changes to the js files which renders the file obsolete.
I can detect the obsolescence of the file by checking of modification dates however what do I do if the file does not exist or is obsolete. should I disable error reporting entirely or just display a warning? keeping in mind that a problem with line number translation may result in inaccuracies of grouping similar reports together on the error report server.
Isn't there option to calculate needed information on the fly when it's not available? I guess it would mean slowdown, but I think that's acceptable for such use.
while the code does not exist, technically it could be created and I think this is a corner case so performance is not an issue. I will work on it. but for now the error reporting is disabled for git repos.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Mohamed Ashraf
participants (4)
-
Dieter Adriaenssens -
Michal Čihař -
Mohamed Ashraf -
Rouslan Placella