Hello,
Apologies in advance if this is not the proper place to ask this question. Also, sorry if this is a double post. I received an email that said the mailing list was for subscribers only and it wasn't clear if my first email was rejected.
I am creating a phpmyadmin theme which I hope to contribute later. I am currently targeting version 4.9.7 for now. I noticed there are certain global variables in the layout.inc.php file for the pmahomme theme. I would like to create a few versions of my theme and it would help if I created additional global variables but I am not sure if that is allowed. Can I create additional global variables or can I only use the global variables defined in the pmahomme theme?
Please advise. Thank you.
Best regards, Andrew
Hi Andrew,
Thanks for reaching out about this. Probably you weren't subscribed to the mailing list at first; Mailman (our mailing list software) can hold messages in that case, but it seems you've subscribed and successfully sent a message.
I'd suggest not targeting a theme for version 4.9, since that is not only an older phpMyAdmin version, but the way themes are built is different. Starting with phpMyAdmin 5.0, we compile themes using SCSS files and some other major differences that don't give a clean upgrade path from version 4.9 themes to version 5.0.
To answer your question, I don't see a problem with you adding more directives in the layout.inc.php file; it's meant to be extended so I believe this is appropriate here.
Thanks, Isaac
On Tue, Sep 21, 2021 at 1:08 PM Andrew Keller < andrew.sigmaprojects@gmail.com> wrote:
Hello,
Apologies in advance if this is not the proper place to ask this question. Also, sorry if this is a double post. I received an email that said the mailing list was for subscribers only and it wasn't clear if my first email was rejected.
I am creating a phpmyadmin theme which I hope to contribute later. I am currently targeting version 4.9.7 for now. I noticed there are certain global variables in the layout.inc.php file for the pmahomme theme. I would like to create a few versions of my theme and it would help if I created additional global variables but I am not sure if that is allowed. Can I create additional global variables or can I only use the global variables defined in the pmahomme theme?
Please advise. Thank you.
Best regards, Andrew _______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Hi Isaac,
Thanks for answering. The reason I'm creating a theme for 4.9 is because I'm creating the theme for personal use and the latest available version in the ubuntu repository is 4.9. Do you happen to know when that will be updated to 5.0 or where I can find out?
I was thinking of just doing a manual install then I can work on a 5.0 version instead.
Best regards, Andrew
On Wed, Sep 22, 2021 at 1:00 PM Isaac Bennetch bennetch@gmail.com wrote:
Hi Andrew,
Thanks for reaching out about this. Probably you weren't subscribed to the mailing list at first; Mailman (our mailing list software) can hold messages in that case, but it seems you've subscribed and successfully sent a message.
I'd suggest not targeting a theme for version 4.9, since that is not only an older phpMyAdmin version, but the way themes are built is different. Starting with phpMyAdmin 5.0, we compile themes using SCSS files and some other major differences that don't give a clean upgrade path from version 4.9 themes to version 5.0.
To answer your question, I don't see a problem with you adding more directives in the layout.inc.php file; it's meant to be extended so I believe this is appropriate here.
Thanks, Isaac
On Tue, Sep 21, 2021 at 1:08 PM Andrew Keller < andrew.sigmaprojects@gmail.com> wrote:
Hello,
Apologies in advance if this is not the proper place to ask this question. Also, sorry if this is a double post. I received an email that said the mailing list was for subscribers only and it wasn't clear if my first email was rejected.
I am creating a phpmyadmin theme which I hope to contribute later. I am currently targeting version 4.9.7 for now. I noticed there are certain global variables in the layout.inc.php file for the pmahomme theme. I would like to create a few versions of my theme and it would help if I created additional global variables but I am not sure if that is allowed. Can I create additional global variables or can I only use the global variables defined in the pmahomme theme?
Please advise. Thank you.
Best regards, Andrew _______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
-
Andrew Keller -
Isaac Bennetch