[Phpmyadmin-devel] [GSOC 2014] New Contributor, fixing bug #3903
Hey all, I am Smita, 1st Year postgraduate student at IIIT, Hyderabad. I am looking forward to participate in GSOC 2014, and thought of contributing to PhpMyAdmin. I have set up the system and was going through the codebase and the buglist. I know its little early but As currently I have my winter vacation, its good time for me to understand the codebase the system. I was able to reproduce the bug #3909[0] and I think I am able to find the reason for the same, the problem is, we are saving the order by preference in the pma db as tablname.column_name and when we query again on same db and the table, it append the saved order by preference tablname.column_name but when using alias it doesn't find tablname.column_name instead it needs either alias.column_name or just order by column_name. so for fixing it, either we can check if the query is using aliasing and if yes then while appending replace the table_name with alias_name in saved preference or while appending the order by just append the column_name from saved preference instead of appending tablname.column_name, I have used latter one to fix it and working fine on my local system. I'm not getting any test case where it may fail. Please suggest if it would be fine. Also, while fixing this bug, i got another bug that is, if instead of ordering on a column using UI we make a query having order by caluse tablname.coloname or just column_name without backquoting. it doesn't retain the preference , actually it saves and delete next time as it doesn't matches with backquoted tablename.colum_name. I have also fixed this issue, by matching the saved preference with unquoted column names from the given table. I think all I have written is not very clear, so I have already sent a pull request, here is the Url https://github.com/phpmyadmin/phpmyadmin/pull/784 Waiting for your feedback!! [0]http://sourceforge.net/p/phpmyadmin/bugs/3903/ Thanks and Regards - Smita Kumari
Smita a écrit :
Hey all,
I am Smita, 1st Year postgraduate student at IIIT, Hyderabad. (...)
Hello Smita and welcome.
I think all I have written is not very clear, so I have already sent a pull request, here is the Url https://github.com/phpmyadmin/phpmyadmin/pull/784
Could you close this pull request and open another one, this time with a commit that you have signed (the -s option of git commit does that). See the CONTRIBUTING.me file for details.
Waiting for your feedback!!
[0]http://sourceforge.net/p/phpmyadmin/bugs/3903/
Thanks and Regards - Smita Kumari
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Hey Marc, Thanks. I have signed the commit and have submitted the pull request https://github.com/phpmyadmin/phpmyadmin/pull/785 on the branch QA_4_1. Please review and let me know if I'm doing something wrong. Thanks and Regrads - Smita Kumari On Thu, Dec 12, 2013 at 11:17 PM, Marc Delisle <marc@infomarc.info> wrote:
Smita a écrit :
Hey all,
I am Smita, 1st Year postgraduate student at IIIT, Hyderabad. (...)
Hello Smita and welcome.
I think all I have written is not very clear, so I have already sent a pull request, here is the Url https://github.com/phpmyadmin/phpmyadmin/pull/784
Could you close this pull request and open another one, this time with a commit that you have signed (the -s option of git commit does that). See the CONTRIBUTING.me file for details.
Waiting for your feedback!!
[0]http://sourceforge.net/p/phpmyadmin/bugs/3903/
Thanks and Regards - Smita Kumari
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2013-12-12 23:53, Smita a écrit :
Hey Marc,
Thanks. I have signed the commit and have submitted the pull request https://github.com/phpmyadmin/phpmyadmin/pull/785 on the branch QA_4_1. Please review and let me know if I'm doing something wrong.
Hi Smita, your second pull request was excellent and it has been merged, thanks. P.S. on this list, we use "bottom posting".
Thanks and Regrads - Smita Kumari
On Thu, Dec 12, 2013 at 11:17 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Smita a écrit : > Hey all, > > I am Smita, 1st Year postgraduate student at IIIT, Hyderabad. (...)
Hello Smita and welcome.
> I think all I have written is not very clear, so I have already sent a > pull request, here is the Url > https://github.com/phpmyadmin/phpmyadmin/pull/784
Could you close this pull request and open another one, this time with a commit that you have signed (the -s option of git commit does that). See the CONTRIBUTING.me file for details.
> > Waiting for your feedback!! > > [0]http://sourceforge.net/p/phpmyadmin/bugs/3903/ > > Thanks and Regards > - Smita Kumari >
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net <mailto:Phpmyadmin-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
participants (2)
-
Marc Delisle -
Smita