[Phpmyadmin-devel] Bug #4301: need suggestion
Hi, I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/ . I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. 2. Append the query itself with separator semicolon in the same existing query box. In this case we'll have same just one Query box having all the Queries appended with separator semicolon. Please let me know if any concern, and what approach we can take to solve the same ? Fixing the bug will also make sure that user will have list of all the queries performed on relation in order that resulted into the results displayed on the page. Thanks and Regards - Smita Kumari
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/ . I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
But IMO, we could skip showing UPDATE query altogether if the user did it with grid edit. Or we could also show SQL query momentarily in the success message that pops up.
2. Append the query itself with separator semicolon in the same existing query box. In this case we'll have same just one Query box having all the Queries appended with separator semicolon.
Please let me know if any concern, and what approach we can take to solve the same ?
Fixing the bug will also make sure that user will have list of all the queries performed on relation in order that resulted into the results displayed on the page.
If you mean showing a sort of history of SQL queries, I don't think main Browse page is suitable place for that. Regards -- Atul Pratap Singh http://blog.atulsisodia.in/
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success popup I think it's fine to just show the updation success message? But IMO, we could skip showing UPDATE query altogether if the user did
it with grid edit. Or we could also show SQL query momentarily in the success message that pops up.
2. Append the query itself with separator semicolon in the same existing query box. In this case we'll have same just one Query box having all the Queries appended with separator semicolon.
Please let me know if any concern, and what approach we can take to solve the same ?
Fixing the bug will also make sure that user will have list of all the queries performed on relation in order that resulted into the results displayed on the page.
If you mean showing a sort of history of SQL queries, I don't think main Browse page is suitable place for that.
Regards -- Atul Pratap Singh http://blog.atulsisodia.in/
Thanks and Regards Smita Kumari
------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success popup I think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well. Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ? [0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/ Regards -- Atul Pratap Singh http://blog.atulsisodia.in/
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success popup I think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards
Atul, yes, I'll modify it as well as the GSoC ideas list. -- Marc Delisle http://infomarc.info | http://phpmyadmin.net
So for now, Should I skip the update query and just show the initial select statement instead? Regards Smita Kumari On Tue, Mar 4, 2014 at 6:57 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success popup I think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards
Atul, yes, I'll modify it as well as the GSoC ideas list.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Smita a écrit :
So for now, Should I skip the update query and just show the initial select statement instead?
My preference would be to show both: the update query and the select query.
Regards Smita Kumari
On Tue, Mar 4, 2014 at 6:57 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success popup I think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards Atul, yes, I'll modify it as well as the GSoC ideas list.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Okay, so I'm keeping the update query above the select query statement same as it shows on page that comes when we click on edit, make changes and click go. Regards - Smita Kumari On Tue, Mar 4, 2014 at 10:55 PM, Marc Delisle <marc@infomarc.info> wrote:
Smita a écrit :
So for now, Should I skip the update query and just show the initial select statement instead?
My preference would be to show both: the update query and the select query.
Regards Smita Kumari
On Tue, Mar 4, 2014 at 6:57 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote: > Hi, > > I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. > I > think, If the query execution is not redirecting page, ie it's > happening on > the same page via an ajax request then there are two ways we can > approach > it. > 1. Append an another Query box below previous Query box for all the > following requests. So in this case, we'll have separate query boxes > for > each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success
popup I
think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards Atul, yes, I'll modify it as well as the GSoC ideas list.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Marc, By showing both the select and update query you mean you want to show the latest update query right? But isn't it better that you show the update query to the user and then change it to select query after a delay, because after all the query box in the browse mode should contain the select query. what is the point of having an update query? I am talking something like this Thanks Krtin On Tue, Mar 4, 2014 at 10:55 PM, Marc Delisle <marc@infomarc.info> wrote:
Smita a écrit :
So for now, Should I skip the update query and just show the initial select statement instead?
My preference would be to show both: the update query and the select query.
Regards Smita Kumari
On Tue, Mar 4, 2014 at 6:57 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote: > Hi, > > I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. > I > think, If the query execution is not redirecting page, ie it's > happening on > the same page via an ajax request then there are two ways we can > approach > it. > 1. Append an another Query box below previous Query box for all the > following requests. So in this case, we'll have separate query boxes > for > each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success
popup I
think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards Atul, yes, I'll modify it as well as the GSoC ideas list.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Marc, By showing both the select and update query you mean you want to show the latest update query right? But isn't it better that you show the update query to the user and then change it to select query after a delay, because after all the query box in the browse mode should contain the select query. what is the point of having an update query? Even if it is required I think having a log of query (as suggested by michal) along with something done in the link below will be better. I am talking something like this https://github.com/phpmyadmin/phpmyadmin/pull/1006 Regards, Krtin On Tue, Mar 4, 2014 at 10:55 PM, Marc Delisle <marc@infomarc.info> wrote:
Smita a écrit :
So for now, Should I skip the update query and just show the initial select statement instead?
My preference would be to show both: the update query and the select query.
Regards Smita Kumari
On Tue, Mar 4, 2014 at 6:57 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On 3/3/14, Smita <kumarismita62@gmail.com> wrote: > Hi, > > I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. > I > think, If the query execution is not redirecting page, ie it's > happening on > the same page via an ajax request then there are two ways we can > approach > it. > 1. Append an another Query box below previous Query box for all the > following requests. So in this case, we'll have separate query boxes > for > each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
Yeah, skipping UPDATE query sounds good to me and In the success
popup I
think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards Atul, yes, I'll modify it as well as the GSoC ideas list.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Krtin Kumar a écrit :
Hi Marc,
By showing both the select and update query you mean you want to show the latest update query right? But isn't it better that you show the update query to the user and then change it to select query after a delay, because after all the query box in the browse mode should contain the select query. what is the point of having an update query? Even if it is required I think having a log of query (as suggested by michal) along with something done in the link below will be better.
I am talking something like this
https://github.com/phpmyadmin/phpmyadmin/pull/1006
Regards, Krtin
Hi Krtin, (please use bottom-posting on this list) I can find a use case for being able to modify both the update query and the select query, but someone will review your pull request. Indeed, the future log of queries should be better: probably that this log would permit to open a query box on any query seen there.
On Tue, Mar 4, 2014 at 10:55 PM, Marc Delisle <marc@infomarc.info> wrote:
Smita a écrit :
So for now, Should I skip the update query and just show the initial select statement instead? My preference would be to show both: the update query and the select query. Regards Smita Kumari
On Tue, Mar 4, 2014 at 6:57 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
On Mon, Mar 3, 2014 at 10:08 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
> On 3/3/14, Smita <kumarismita62@gmail.com> wrote: >> Hi, >> >> I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/. >> I >> think, If the query execution is not redirecting page, ie it's >> happening > on >> the same page via an ajax request then there are two ways we can >> approach >> it. >> 1. Append an another Query box below previous Query box for all the >> following requests. So in this case, we'll have separate query boxes >> for >> each operation performed on the page. > Smita, > Similar behavior occurs when:- > In Browse mode, click on "Edit" in a table row => On edit page change > something and click Go => see two SQL query boxes with UPDATE query > box on top not below. > Yeah, skipping UPDATE query sounds good to me and In the success popup I think it's fine to just show the updation success message?
Yes, for the purpose of this bug, its fine for me to skip showing the query. But indeed we need to have a full SQL log/history as well.
Marc, Can we modify [0] to include implementing a full SQL log/history feature as suggested by Michal ?
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1492/
Regards Atul, yes, I'll modify it as well as the GSoC ideas list.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Hi Dne Mon, 3 Mar 2014 22:08:16 +0530 Atul Pratap Singh <atulpratapsingh05@gmail.com> napsal(a):
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/ . I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
But IMO, we could skip showing UPDATE query altogether if the user did it with grid edit. Or we could also show SQL query momentarily in the success message that pops up.
Actually I've heard quite some complains that phpMyAdmin no longer shows performed SQL queries in some cases. I think having some SQL log at the bottom (like was shown at http://pmademo.byethost7.com/) would really helpful in such situations - it would show every SQL query, while not disturbing user experience. -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
On 3/3/14, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 3 Mar 2014 22:08:16 +0530 Atul Pratap Singh <atulpratapsingh05@gmail.com> napsal(a):
On 3/3/14, Smita <kumarismita62@gmail.com> wrote:
Hi,
I was looking at the bug http://sourceforge.net/p/phpmyadmin/bugs/4301/ . I think, If the query execution is not redirecting page, ie it's happening on the same page via an ajax request then there are two ways we can approach it. 1. Append an another Query box below previous Query box for all the following requests. So in this case, we'll have separate query boxes for each operation performed on the page. Smita, Similar behavior occurs when:- In Browse mode, click on "Edit" in a table row => On edit page change something and click Go => see two SQL query boxes with UPDATE query box on top not below.
But IMO, we could skip showing UPDATE query altogether if the user did it with grid edit. Or we could also show SQL query momentarily in the success message that pops up.
Actually I've heard quite some complains that phpMyAdmin no longer shows performed SQL queries in some cases. I think having some SQL log at the bottom (like was shown at http://pmademo.byethost7.com/) would really helpful in such situations - it would show every SQL query, while not disturbing user experience.
The feature sounds must have to me. Regards, -- Atul Pratap Singh http://blog.atulsisodia.in/
participants (5)
-
Atul Pratap Singh -
Krtin Kumar -
Marc Delisle -
Michal Čihař -
Smita