Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c4421d064d16df3da41690c6925b3eb89a1ef282 https://github.com/phpmyadmin/phpmyadmin/commit/c4421d064d16df3da41690c6925b... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/ConfigStorage/Relation.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml
Log Message: ----------- Improve type hint
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 3b611f39451cc843fe5965fd939d1da79aad59ad https://github.com/phpmyadmin/phpmyadmin/commit/3b611f39451cc843fe5965fd939d... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: A libraries/classes/ColumnFull.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php
Log Message: ----------- Implement ColumnFull DTO
This is MVP. In following commits the DTO will be expanded and improved.
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 2c9153ac5d9702ddfa728ed9e60dcfcd0013649d https://github.com/phpmyadmin/phpmyadmin/commit/2c9153ac5d9702ddfa728ed9e60d... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php
Log Message: ----------- Refactor column length calculation
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 0d9e7958902a55627fadb79ca2eeadcf112d84a9 https://github.com/phpmyadmin/phpmyadmin/commit/0d9e7958902a55627fadb79ca2ee... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/DatabaseInterface.php M phpstan-baseline.neon M psalm-baseline.xml
Log Message: ----------- Narrow down type of SHOW COLUMNS
MySQL clearly defines the structure of the fields for SHOW [FULL] COLUMNS. We can be sure it will be either string or null.
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 0aa3210ee10be006cd6ac4f8d7545329f7c5929d https://github.com/phpmyadmin/phpmyadmin/commit/0aa3210ee10be006cd6ac4f8d754... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M phpstan-baseline.neon M psalm-baseline.xml
Log Message: ----------- Use array shape instead of (string|null)[]
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: fccaaf65a390d5ccbfaf6e312562871a3ee425b2 https://github.com/phpmyadmin/phpmyadmin/commit/fccaaf65a390d5ccbfaf6e312562... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Normalization.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/StructureControllerTest.php
Log Message: ----------- Remove all new Psalm issues
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 1d180c54825a9443bc5bbfc8eb61fc93815b6005 https://github.com/phpmyadmin/phpmyadmin/commit/1d180c54825a9443bc5bbfc8eb61... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/Controllers/Table/Structure/ChangeController.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M phpstan-baseline.neon M psalm-baseline.xml
Log Message: ----------- Use null as sentinel value in getColumn
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 43a864b50fce42dd5c5c4260be9de9614ebae0a2 https://github.com/phpmyadmin/phpmyadmin/commit/43a864b50fce42dd5c5c4260be9d... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M test/classes/InsertEditTest.php
Log Message: ----------- Assign Default inside analyzeTableColumnsArray
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 56136bb350c701c26719a8bd1316bb252778a73f https://github.com/phpmyadmin/phpmyadmin/commit/56136bb350c701c26719a8bd1316... Author: Kamil Tekiela tekiela246@gmail.com Date: 2023-05-19 (Fri, 05 May 2023) +01:00
Changed paths: M test/classes/Stubs/DbiDummy.php
Log Message: ----------- Fix failing test
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Commit: 30ff7d4b6a790538bd9aa9cd55d021ef7a0751b8 https://github.com/phpmyadmin/phpmyadmin/commit/30ff7d4b6a790538bd9aa9cd55d0... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2023-05-23 (Tue, 05 May 2023) -03:00
Changed paths: A libraries/classes/ColumnFull.php M libraries/classes/ConfigStorage/Relation.php M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/Structure/ChangeController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M libraries/classes/InsertEdit.php M libraries/classes/Normalization.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/InsertEditTest.php M test/classes/Stubs/DbiDummy.php
Log Message: ----------- Merge pull request #18434 from kamil-tekiela/InsertEdit-pt-3
InsertEdit refactoring - part 3