[phpMyAdmin Git] [phpmyadmin/phpmyadmin] a2a35c: Split up loadFirstRow

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a2a35c19de86cbd15a0088fc58f5cc7533e78bae https://github.com/phpmyadmin/phpmyadmin/commit/a2a35c19de86cbd15a0088fc58f… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Split up loadFirstRow Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0bb63c997f7ec90fba6cd70c04ba64f4307c6d55 https://github.com/phpmyadmin/phpmyadmin/commit/0bb63c997f7ec90fba6cd70c04b… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Remove getWhereClauseArray() This weird array cast is not adding anything useful. The psalm type hint tells us that elements are strings, but that's not guaranteed in any way. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9800c3574fc4bd8be0aaa5cca021cc5b354fc269 https://github.com/phpmyadmin/phpmyadmin/commit/9800c3574fc4bd8be0aaa5cca02… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Move urlParamsInEditMode to ChangeController Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: aa689f04f33d3549f3087e84ce74a47247ad62e9 https://github.com/phpmyadmin/phpmyadmin/commit/aa689f04f33d3549f3087e84ce7… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Drop getEnumSetAndTimestampColumns() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 2d7617fe475633805187c472f02dd66d34444590 https://github.com/phpmyadmin/phpmyadmin/commit/2d7617fe475633805187c472f02… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M test/classes/InsertEditTest.php Log Message: ----------- Drop getColumnEnumValues() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: fa7fe0da9716413992a90ea08e2dad1ea48f83e5 https://github.com/phpmyadmin/phpmyadmin/commit/fa7fe0da9716413992a90ea08e2… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M test/classes/InsertEditTest.php Log Message: ----------- Drop getColumnSetValueAndSelectSize() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 3c6fbee97c731efab1e2cf8c7979e009f38ffdee https://github.com/phpmyadmin/phpmyadmin/commit/3c6fbee97c731efab1e2cf8c797… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M test/classes/InsertEditTest.php Log Message: ----------- getMaxUploadSize() should only return string Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8367af19be95ddd5118fc63ddf08046692293b77 https://github.com/phpmyadmin/phpmyadmin/commit/8367af19be95ddd5118fc63ddf0… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Remove unused $biggestMaxFileSize param Not sure if it should have been a global, but judging by the rest of the code, I believe it's no longer needed. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 56d1eed3581d1d910e394e982ac493ee3c13dcb8 https://github.com/phpmyadmin/phpmyadmin/commit/56d1eed3581d1d910e394e982ac… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M js/src/drag_drop_import.ts M libraries/classes/Controllers/Import/ImportController.php M psalm-baseline.xml M templates/import.twig M templates/preferences/manage/main.twig Log Message: ----------- Remove MAX_FILE_SIZE This is not used anywhere in frontend or backend. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: d10d11bf8f68afac971c2351dcf86413eca3ad95 https://github.com/phpmyadmin/phpmyadmin/commit/d10d11bf8f68afac971c2351dcf… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Add missing @psalm-return Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9640a765560b337033dc0b52a23bc3559b16f90a https://github.com/phpmyadmin/phpmyadmin/commit/9640a765560b337033dc0b52a23… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Move $specialCharsEncoded out of getSpecialCharsAndBackupFieldForInsertingMode Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 15f1fc44e76e6b9255be2f16e39e11e468c69dd6 https://github.com/phpmyadmin/phpmyadmin/commit/15f1fc44e76e6b9255be2f16e39… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Unwind getSpecialCharsAndBackupFieldForInsertingMode() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a852acb3e95a938d214982d8208484204457909a https://github.com/phpmyadmin/phpmyadmin/commit/a852acb3e95a938d214982d8208… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Move $isInsertignore out of getParamsForUpdateOrInsert Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 25b24966c11e2a2e8e7fe0f5b30bf003137ba581 https://github.com/phpmyadmin/phpmyadmin/commit/25b24966c11e2a2e8e7fe0f5b30… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Move getParamsForUpdateOrInsert into controller Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 5cd6c166842d11ec6208ce5e2460d0d45d30074a https://github.com/phpmyadmin/phpmyadmin/commit/5cd6c166842d11ec6208ce5e246… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Instead of returning array, use array cast Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0d2432580b1c9144bbc839431929c3c07580dfef https://github.com/phpmyadmin/phpmyadmin/commit/0d2432580b1c9144bbc83943192… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-23 (Sun, 04 April 2023) -03:00 Changed paths: M js/src/drag_drop_import.ts M libraries/classes/Controllers/Import/ImportController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/import.twig M templates/preferences/manage/main.twig M templates/table/insert/column_row.twig M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Merge pull request #18359 from kamil-tekiela/InsertEdit-refactoring InsertEdit refactoring - part 1