[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 902d1a: Add native return type hints (#18126)

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 902d1a1e778b2a356a9535dd0b81c057d1d81fb9 https://github.com/phpmyadmin/phpmyadmin/commit/902d1a1e778b2a356a9535dd0b8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-02-23 (Thu, 02 February 2023) -03:00 Changed paths: M libraries/classes/Advisory/Advisor.php M libraries/classes/Cache.php M libraries/classes/Charsets.php M libraries/classes/Config.php M libraries/classes/Config/ConfigFile.php M libraries/classes/Config/Descriptions.php M libraries/classes/Config/Form.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Config/Forms/BaseForm.php M libraries/classes/Config/Forms/BaseFormList.php M libraries/classes/Config/Forms/Page/BrowseForm.php M libraries/classes/Config/Forms/Page/DbStructureForm.php M libraries/classes/Config/Forms/Page/EditForm.php M libraries/classes/Config/Forms/Page/TableStructureForm.php M libraries/classes/Config/Forms/Setup/ConfigForm.php M libraries/classes/Config/Forms/Setup/FeaturesForm.php M libraries/classes/Config/Forms/Setup/MainForm.php M libraries/classes/Config/Forms/Setup/ServersForm.php M libraries/classes/Config/Forms/Setup/SqlForm.php M libraries/classes/Config/Forms/User/ExportForm.php M libraries/classes/Config/Forms/User/FeaturesForm.php M libraries/classes/Config/Forms/User/ImportForm.php M libraries/classes/Config/Forms/User/MainForm.php M libraries/classes/Config/Forms/User/NaviForm.php M libraries/classes/Config/Forms/User/SqlForm.php M libraries/classes/Config/ServerConfigChecks.php M libraries/classes/Config/Validator.php M libraries/classes/ConfigStorage/Relation.php M libraries/classes/Controllers/Database/CentralColumnsController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Core.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Database/Events.php M libraries/classes/Database/MultiTableQuery.php M libraries/classes/Database/Qbe.php M libraries/classes/Database/Routines.php M libraries/classes/Database/Search.php M libraries/classes/Database/Triggers.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M libraries/classes/Dbal/DbiExtension.php M libraries/classes/Dbal/DbiMysqli.php M libraries/classes/Dbal/MysqliResult.php M libraries/classes/Dbal/ResultInterface.php M libraries/classes/Display/Results.php M libraries/classes/Engines/Bdb.php M libraries/classes/Engines/Binlog.php M libraries/classes/Engines/Innodb.php M libraries/classes/Engines/Memory.php M libraries/classes/Engines/MrgMyisam.php M libraries/classes/Engines/Myisam.php M libraries/classes/Engines/Ndbcluster.php M libraries/classes/Engines/Pbxt.php M libraries/classes/Engines/PerformanceSchema.php M libraries/classes/ErrorReport.php M libraries/classes/Export.php M libraries/classes/Export/Options.php M libraries/classes/Footer.php M libraries/classes/Gis/GisGeometry.php M libraries/classes/Gis/GisGeometryCollection.php M libraries/classes/Gis/GisLineString.php M libraries/classes/Gis/GisMultiLineString.php M libraries/classes/Gis/GisMultiPoint.php M libraries/classes/Gis/GisMultiPolygon.php M libraries/classes/Gis/GisPoint.php M libraries/classes/Gis/GisPolygon.php M libraries/classes/Gis/GisVisualization.php M libraries/classes/Git.php M libraries/classes/Http/ServerRequest.php M libraries/classes/Index.php M libraries/classes/IndexColumn.php M libraries/classes/InsertEdit.php M libraries/classes/Language.php M libraries/classes/LanguageManager.php M libraries/classes/Linter.php M libraries/classes/ListAbstract.php M libraries/classes/ListDatabase.php M libraries/classes/Logging.php M libraries/classes/Menu.php M libraries/classes/Message.php M libraries/classes/Mime.php M libraries/classes/Navigation/Navigation.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Navigation/Nodes/NodeColumn.php M libraries/classes/Navigation/Nodes/NodeDatabase.php M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php M libraries/classes/Navigation/Nodes/NodeDatabaseChildContainer.php M libraries/classes/Navigation/Nodes/NodeEvent.php M libraries/classes/Navigation/Nodes/NodeFunction.php M libraries/classes/Navigation/Nodes/NodeProcedure.php M libraries/classes/Navigation/Nodes/NodeTable.php M libraries/classes/Navigation/Nodes/NodeView.php M libraries/classes/Normalization.php M libraries/classes/OpenDocument.php M libraries/classes/Operations.php M libraries/classes/OutputBuffering.php M libraries/classes/Partitioning/Partition.php M libraries/classes/Partitioning/SubPartition.php M libraries/classes/Plugins.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/Export/ExportCodegen.php M libraries/classes/Plugins/Export/ExportHtmlword.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/ExportMediawiki.php M libraries/classes/Plugins/Export/ExportOdt.php M libraries/classes/Plugins/Export/ExportPdf.php M libraries/classes/Plugins/Export/ExportPhparray.php M libraries/classes/Plugins/Export/ExportTexytext.php M libraries/classes/Plugins/Export/ExportXml.php M libraries/classes/Plugins/Export/Helpers/TableProperty.php M libraries/classes/Plugins/ExportPlugin.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Plugins/Import/ImportMediawiki.php M libraries/classes/Plugins/Import/ImportShp.php M libraries/classes/Plugins/Import/Upload/UploadNoplugin.php M libraries/classes/Plugins/Import/Upload/UploadProgress.php M libraries/classes/Plugins/Import/Upload/UploadSession.php M libraries/classes/Plugins/ImportPlugin.php M libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php M libraries/classes/Plugins/Schema/Eps/Eps.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/TableStatsPdf.php M libraries/classes/Plugins/Schema/RelationStats.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/classes/Plugins/SchemaPlugin.php M libraries/classes/Plugins/Transformations/Abs/Bool2TextTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/DownloadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/FormattedTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/HexTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageLinkTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/InlineTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/LongToIPv4TransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/PreApPendTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/RegexValidationTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/SQLTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/SubstringTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextImageLinkTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextLinkTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M libraries/classes/Plugins/Transformations/Output/Text_Plain_Binarytoip.php M libraries/classes/Plugins/Transformations/Output/Text_Plain_Json.php M libraries/classes/Plugins/Transformations/Output/Text_Plain_Xml.php M libraries/classes/Plugins/TransformationsPlugin.php M libraries/classes/Plugins/TwoFactor/Application.php M libraries/classes/Plugins/TwoFactor/Invalid.php M libraries/classes/Plugins/TwoFactor/Key.php M libraries/classes/Plugins/TwoFactor/Simple.php M libraries/classes/Plugins/TwoFactorPlugin.php M libraries/classes/Plugins/UploadInterface.php M libraries/classes/Query/Cache.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/Replication.php M libraries/classes/ResponseRenderer.php M libraries/classes/Sanitize.php M libraries/classes/SavedSearches.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/Select.php M libraries/classes/Server/Status/Data.php M libraries/classes/Server/Status/Monitor.php M libraries/classes/Server/SysInfo/SysInfo.php M libraries/classes/Setup/ConfigGenerator.php M libraries/classes/Setup/Index.php M libraries/classes/Sql.php M libraries/classes/SqlQueryForm.php M libraries/classes/StorageEngine.php M libraries/classes/SystemDatabase.php M libraries/classes/Table.php M libraries/classes/Theme.php M libraries/classes/ThemeManager.php M libraries/classes/Tracker.php M libraries/classes/Tracking.php M libraries/classes/Transformations.php M libraries/classes/Twig/AssetExtension.php M libraries/classes/Twig/CoreExtension.php M libraries/classes/Twig/I18nExtension.php M libraries/classes/Twig/MessageExtension.php M libraries/classes/Twig/SanitizeExtension.php M libraries/classes/Twig/TableExtension.php M libraries/classes/Twig/TrackerExtension.php M libraries/classes/Twig/TransformationsExtension.php M libraries/classes/Twig/UrlExtension.php M libraries/classes/Twig/UtilExtension.php M libraries/classes/TwoFactor.php M libraries/classes/Types.php M libraries/classes/Url.php M libraries/classes/UserPassword.php M libraries/classes/UserPreferences.php M libraries/classes/Util.php M libraries/classes/Utils/FormatConverter.php M libraries/classes/Utils/Gis.php M libraries/classes/Utils/HttpRequest.php M libraries/classes/Utils/SessionCache.php M libraries/classes/VersionInformation.php M libraries/classes/WebAuthn/CBORDecoder.php M libraries/classes/ZipExtension.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/CharsetsTest.php M test/classes/Export/OptionsTest.php M test/classes/IndexTest.php M test/classes/NormalizationTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/SqlTest.php M test/classes/Stubs/DbiDummy.php M test/classes/Stubs/DummyResult.php M test/classes/Stubs/ResponseRenderer.php M test/classes/TableTest.php M test/classes/UserPreferencesTest.php M test/classes/UtilTest.php M test/classes/ZipExtensionTest.php Log Message: ----------- Add native return type hints (#18126) * Add remaining native return type hints to flush out bugs Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Cast the mixed value to int Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Fix tests Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * getAutoIncrement() is supposed to return string Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Cast values to string in DummyResult Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Make getCollation() return non-nullable string Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Cast seqInIndex to int Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Cast $cardinality to int Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * createFile may return false Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove redundant cast Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update baselines Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> --------- Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>