[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 10745b: #15363 - substr can return false

Branch: refs/heads/QA_5_0 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 10745bb39275a6f5ac7c62c063fa6433dfc8854b https://github.com/phpmyadmin/phpmyadmin/commit/10745bb39275a6f5ac7c62c063f… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-20 (Tue, 08 August 2019) +02:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- #15363 - substr can return false Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: da9d907ad1b17c31d293bff56f10fdaca52672c1 https://github.com/phpmyadmin/phpmyadmin/commit/da9d907ad1b17c31d293bff56f1… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-20 (Tue, 08 August 2019) +02:00 Changed paths: M js/designer/move.js M templates/database/designer/database_tables.twig Log Message: ----------- Fix #15446 Tables added from other databases are not collapsing in the designer section The events to link all buttons to collapse tables were initialized at page loading. But when a new table was added, the event wasn't declared for this one. With this commit, the event is now also declared on table addition. Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: 49dae2de12742b87a28cc6aa6c5e768be91d1b99 https://github.com/phpmyadmin/phpmyadmin/commit/49dae2de12742b87a28cc6aa6c5… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-20 (Tue, 08 August 2019) +02:00 Changed paths: M db_designer.php Log Message: ----------- Fix wrong id on table When a table is added on the fly, the id was always built based on the first table of the targetted DB, not based on the selected table. Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: 14ba5a1b248791c71ad9e621330d4b4f361722bd https://github.com/phpmyadmin/phpmyadmin/commit/14ba5a1b248791c71ad9e621330… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-20 (Tue, 08 August 2019) +02:00 Changed paths: M js/designer/move.js M libraries/classes/Database/Designer.php M templates/database/designer/database_tables.twig M templates/database/designer/table_list.twig Log Message: ----------- Retrieve DB instead of relying on current one When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure. Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: c23bec2dee77f4b9af19f04f58d78db7cc75f5c4 https://github.com/phpmyadmin/phpmyadmin/commit/c23bec2dee77f4b9af19f04f58d… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-20 (Tue, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Be sure to use local variable Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: de57539fb71beacba54b18283893ca3cba6f01cf https://github.com/phpmyadmin/phpmyadmin/commit/de57539fb71beacba54b1828389… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M db_designer.php M js/designer/move.js M js/messages.php M libraries/classes/Database/Designer.php M templates/database/designer/table_list.twig Log Message: ----------- Build "tables list" in JS This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list. Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: ac340e29b6c53c4722789650c9500891c6b1f5e8 https://github.com/phpmyadmin/phpmyadmin/commit/ac340e29b6c53c4722789650c95… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Add missing overlay on added tables Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: b13c05edfa5effe098516ca6db4b84b3d9ea8693 https://github.com/phpmyadmin/phpmyadmin/commit/b13c05edfa5effe098516ca6db4… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Toggling global collapse of tables now relies on tables items instead of j_tabs Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: fce235c7bcc49793f2914a00790e573f3c8d5386 https://github.com/phpmyadmin/phpmyadmin/commit/fce235c7bcc49793f2914a00790… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Remove variable that is unused anymore Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: 3aa7a35daebd2b1f816ac97ffe3822af032bc0f2 https://github.com/phpmyadmin/phpmyadmin/commit/3aa7a35daebd2b1f816ac97ffe3… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M libraries/tbl_columns_definition_form.inc.php Log Message: ----------- #15363 - substr can return false on tbl_definition_form Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 67c94b17fd04ec4ba22b4f8e5dcf9d3e3ab94eec https://github.com/phpmyadmin/phpmyadmin/commit/67c94b17fd04ec4ba22b4f8e5dc… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Designer export fails when a table name contains special chars Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: b37b479da03b02cab23ce039ecb299496afa6b6d https://github.com/phpmyadmin/phpmyadmin/commit/b37b479da03b02cab23ce039ecb… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-21 (Wed, 08 August 2019) +02:00 Changed paths: M js/designer/move.js M js/messages.php Log Message: ----------- Display an error when trying to import in designer a table that's already imported Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: 4f832662c5379cb61c932433623d48b68de9b91d https://github.com/phpmyadmin/phpmyadmin/commit/4f832662c5379cb61c932433623… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-22 (Thu, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Merge #15451 - Designer export fails when a table name contains special chars Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 5c7eb38a81712679c354d13cc9355e27db2eba21 https://github.com/phpmyadmin/phpmyadmin/commit/5c7eb38a81712679c354d13cc93… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-22 (Thu, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Fix url encoding of table names Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: 58e3b71ae251a6234551af6892f49942577cfacb https://github.com/phpmyadmin/phpmyadmin/commit/58e3b71ae251a6234551af6892f… Author: Hugues Peccatte <hugues.peccatte(a)gmail.com> Date: 2019-08-22 (Thu, 08 August 2019) +02:00 Changed paths: M js/messages.php Log Message: ----------- Update js/messages.php add context for translators Co-Authored-By: William Desportes <williamdes(a)wdes.fr> Signed-off-by: Hugues Peccatte <hugues.peccatte(a)gmail.com> Commit: 9518e0d05304e7994dab70674f582dd86cfd4ab4 https://github.com/phpmyadmin/phpmyadmin/commit/9518e0d05304e7994dab70674f5… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-22 (Thu, 08 August 2019) +02:00 Changed paths: M js/designer/move.js M js/messages.php Log Message: ----------- Merge #15452 - Display an error when trying to import in designer a table that's already imported Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 5940d11e72c4a9fa5c4a3beb24d3c2db9d4b0277 https://github.com/phpmyadmin/phpmyadmin/commit/5940d11e72c4a9fa5c4a3beb24d… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-22 (Thu, 08 August 2019) +02:00 Changed paths: M db_designer.php M js/designer/move.js M js/messages.php M libraries/classes/Database/Designer.php M templates/database/designer/database_tables.twig M templates/database/designer/table_list.twig Log Message: ----------- Merge #15448 - Fix many bugs when adding new tables to designer Fixes: #15446 Pull-request: #15448 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: a23f2ba51a93af0c5eedf91646aa9e04b9bc3a12 https://github.com/phpmyadmin/phpmyadmin/commit/a23f2ba51a93af0c5eedf91646a… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: A libraries/classes/Database/Designer/DesignerTable.php M db_designer.php M js/designer/move.js M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Export.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/TableStats.php M schema_export.php M templates/database/designer/database_tables.twig Log Message: ----------- Fix some bugs with strange table and database names - Fix export - Fix split on . to have db and table - Replace some $_REQUEST occurences - Add translations to "add tables from another database" : "None" > strNone - Refactor the ugly code that used globals to use an object "DesignerTable" - Fix save a new added table - Fix delete page items - Fix more bugs Fixes: #15446 Fixes: #13370 Fixes: #14945 Closes: #15438 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 9c5195d438f85fab78c79f280276e3f184a0116a https://github.com/phpmyadmin/phpmyadmin/commit/9c5195d438f85fab78c79f28027… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: M test/classes/Database/Designer/CommonTest.php M test/classes/Plugins/Schema/DiaRelationSchemaTest.php M test/classes/Plugins/Schema/EpsRelationSchemaTest.php M test/classes/Plugins/Schema/PdfRelationSchemaTest.php M test/classes/Plugins/Schema/SvgRelationSchemaTest.php Log Message: ----------- Fix Unit tests broken by a23f2ba51a93af0c5e Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 6d0f3083ca7f9d993c98a538e8b79b7a32462428 https://github.com/phpmyadmin/phpmyadmin/commit/6d0f3083ca7f9d993c98a538e8b… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: M libraries/classes/Database/Designer/Common.php Log Message: ----------- Fix display field can return a boolean [ci skip] Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 027f39057a18d91baf7f89081cb48a7ffc43bfda https://github.com/phpmyadmin/phpmyadmin/commit/027f39057a18d91baf7f89081cb… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: A libraries/classes/Database/Designer/DesignerTable.php M db_designer.php M js/designer/move.js M js/messages.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Export.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/tbl_columns_definition_form.inc.php M schema_export.php M templates/database/designer/database_tables.twig M templates/database/designer/main.twig M test/classes/Database/Designer/CommonTest.php M test/classes/Plugins/Schema/DiaRelationSchemaTest.php M test/classes/Plugins/Schema/EpsRelationSchemaTest.php M test/classes/Plugins/Schema/PdfRelationSchemaTest.php M test/classes/Plugins/Schema/SvgRelationSchemaTest.php M themes/pmahomme/scss/_designer.scss Log Message: ----------- Merge branch 'QA_4_9' into QA_5_0 - Fixed css img urls for designer Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 8590357612116753514f01c4b1c49b3bcd335ef8 https://github.com/phpmyadmin/phpmyadmin/commit/8590357612116753514f01c4b1c… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: M js/designer/move.js Log Message: ----------- Fix a bug introduced by a23f2ba51a93af0c5 [ci skip] Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 4f5a17182642ebcdebc0812666e71b2e5b05657f https://github.com/phpmyadmin/phpmyadmin/commit/4f5a17182642ebcdebc0812666e… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: M po/af.po M po/ar.po M po/az.po M po/be.po M po/be(a)latin.po M po/bg.po M po/bn.po M po/br.po M po/brx.po M po/bs.po M po/ca.po M po/ckb.po M po/cs.po M po/cy.po M po/da.po M po/de.po M po/el.po M po/en_GB.po M po/eo.po M po/es.po M po/et.po M po/eu.po M po/fa.po M po/fi.po M po/fil.po M po/fr.po M po/fy.po M po/gl.po M po/gu.po M po/he.po M po/hi.po M po/hr.po M po/hu.po M po/hy.po M po/ia.po M po/id.po M po/ig.po M po/it.po M po/ja.po M po/ka.po M po/kab.po M po/kk.po M po/km.po M po/kn.po M po/ko.po M po/ksh.po M po/ku.po M po/ky.po M po/li.po M po/lt.po M po/lv.po M po/mk.po M po/ml.po M po/mn.po M po/ms.po M po/my.po M po/nb.po M po/ne.po M po/nl.po M po/nn.po M po/pa.po M po/phpmyadmin.pot M po/pl.po M po/pt.po M po/pt_BR.po M po/ro.po M po/ru.po M po/si.po M po/sk.po M po/sl.po M po/sq.po M po/sr.po M po/sr(a)latin.po M po/sv.po M po/ta.po M po/te.po M po/th.po M po/tk.po M po/tr.po M po/tt.po M po/ug.po M po/uk.po M po/ur.po M po/uz.po M po/uz(a)latin.po M po/vi.po M po/vls.po M po/zh_CN.po M po/zh_TW.po Log Message: ----------- Update po files [ci skip] Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 1af61f88b3ad5bdec54594e1744c6deb4b6368e3 https://github.com/phpmyadmin/phpmyadmin/commit/1af61f88b3ad5bdec54594e1744… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: M js/designer/move.js M libraries/classes/Database/Designer/Common.php Log Message: ----------- Merge branch 'QA_4_9' into QA_5_0 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 564894ce46e37de05cfb24461caf32ad48c23954 https://github.com/phpmyadmin/phpmyadmin/commit/564894ce46e37de05cfb24461ca… Author: William Desportes <williamdes(a)wdes.fr> Date: 2019-08-23 (Fri, 08 August 2019) +02:00 Changed paths: M po/af.po M po/ar.po M po/az.po M po/be.po M po/be(a)latin.po M po/bg.po M po/bn.po M po/br.po M po/brx.po M po/bs.po M po/ca.po M po/ckb.po M po/cs.po M po/cy.po M po/da.po M po/de.po M po/el.po M po/en_GB.po M po/eo.po M po/es.po M po/et.po M po/eu.po M po/fa.po M po/fi.po M po/fil.po M po/fr.po M po/fy.po M po/gl.po M po/gu.po M po/he.po M po/hi.po M po/hr.po M po/hu.po M po/hy.po M po/ia.po M po/id.po M po/ig.po M po/it.po M po/ja.po M po/ka.po M po/kab.po M po/kk.po M po/km.po M po/kn.po M po/ko.po M po/ksh.po M po/ku.po M po/ky.po M po/li.po M po/lt.po M po/lv.po M po/mk.po M po/ml.po M po/mn.po M po/ms.po M po/my.po M po/nb.po M po/ne.po M po/nl.po M po/nn.po M po/pa.po M po/phpmyadmin.pot M po/pl.po M po/pt.po M po/pt_BR.po M po/ro.po M po/ru.po M po/si.po M po/sk.po M po/sl.po M po/sq.po M po/sr.po M po/sr(a)latin.po M po/sv.po M po/ta.po M po/te.po M po/th.po M po/tk.po M po/tr.po M po/tt.po M po/ug.po M po/uk.po M po/ur.po M po/uz.po M po/uz(a)latin.po M po/vi.po M po/vls.po M po/zh_CN.po M po/zh_TW.po Log Message: ----------- Update po files [ci skip] Signed-off-by: William Desportes <williamdes(a)wdes.fr>