[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 0bdcab: Add native property types (#18143)

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 0bdcaba2d23aeeb3fc81e6057a2517ac504b3708 https://github.com/phpmyadmin/phpmyadmin/commit/0bdcaba2d23aeeb3fc81e6057a2… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-02-26 (Sun, 02 February 2023) -03:00 Changed paths: M libraries/classes/Advisory/Advisor.php M libraries/classes/Bookmark.php M libraries/classes/BrowseForeigners.php M libraries/classes/Cache.php M libraries/classes/Charsets.php M libraries/classes/Common.php M libraries/classes/Config.php M libraries/classes/Config/ConfigFile.php M libraries/classes/Config/Form.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Config/FormDisplayTemplate.php M libraries/classes/Config/Forms/BaseFormList.php M libraries/classes/Config/Forms/Page/PageFormList.php M libraries/classes/Config/Forms/Setup/SetupFormList.php M libraries/classes/Config/Forms/User/UserFormList.php M libraries/classes/Config/PageSettings.php M libraries/classes/Config/Settings.php M libraries/classes/Config/Settings/Console.php M libraries/classes/Config/Settings/Debug.php M libraries/classes/Config/Settings/Export.php M libraries/classes/Config/Settings/Import.php M libraries/classes/Config/Settings/Schema.php M libraries/classes/Config/Settings/Server.php M libraries/classes/Config/Settings/SqlQueryBox.php M libraries/classes/Config/Settings/Transformations.php M libraries/classes/ConfigStorage/Features/BookmarkFeature.php M libraries/classes/ConfigStorage/Features/BrowserTransformationFeature.php M libraries/classes/ConfigStorage/Features/CentralColumnsFeature.php M libraries/classes/ConfigStorage/Features/ColumnCommentsFeature.php M libraries/classes/ConfigStorage/Features/ConfigurableMenusFeature.php M libraries/classes/ConfigStorage/Features/DatabaseDesignerSettingsFeature.php M libraries/classes/ConfigStorage/Features/DisplayFeature.php M libraries/classes/ConfigStorage/Features/ExportTemplatesFeature.php M libraries/classes/ConfigStorage/Features/FavoriteTablesFeature.php M libraries/classes/ConfigStorage/Features/NavigationItemsHidingFeature.php M libraries/classes/ConfigStorage/Features/PdfFeature.php M libraries/classes/ConfigStorage/Features/RecentlyUsedTablesFeature.php M libraries/classes/ConfigStorage/Features/RelationFeature.php M libraries/classes/ConfigStorage/Features/SavedQueryByExampleSearchesFeature.php M libraries/classes/ConfigStorage/Features/SqlHistoryFeature.php M libraries/classes/ConfigStorage/Features/TrackingFeature.php M libraries/classes/ConfigStorage/Features/UiPreferencesFeature.php M libraries/classes/ConfigStorage/Features/UserPreferencesFeature.php M libraries/classes/ConfigStorage/RelationCleanup.php M libraries/classes/Console.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/HomeController.php M libraries/classes/Controllers/Server/DatabasesController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/GisVisualizationController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Events.php M libraries/classes/Database/MultiTableQuery.php M libraries/classes/Database/Qbe.php M libraries/classes/Database/Routines.php M libraries/classes/Database/Search.php M libraries/classes/Database/Triggers.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/Connection.php M libraries/classes/Dbal/DatabaseName.php M libraries/classes/Dbal/TableName.php M libraries/classes/Dbal/Warning.php M libraries/classes/Display/DisplayParts.php M libraries/classes/Display/Results.php M libraries/classes/EditField.php M libraries/classes/Encoding.php M libraries/classes/Error.php M libraries/classes/ErrorHandler.php M libraries/classes/ErrorReport.php M libraries/classes/Export.php M libraries/classes/FieldMetadata.php M libraries/classes/File.php M libraries/classes/FlashMessages.php M libraries/classes/Footer.php M libraries/classes/Gis/GisGeometryCollection.php M libraries/classes/Gis/GisLineString.php M libraries/classes/Gis/GisMultiLineString.php M libraries/classes/Gis/GisMultiPoint.php M libraries/classes/Gis/GisMultiPolygon.php M libraries/classes/Gis/GisPoint.php M libraries/classes/Gis/GisPolygon.php M libraries/classes/Gis/GisVisualization.php M libraries/classes/Git.php M libraries/classes/Header.php M libraries/classes/Import.php M libraries/classes/Index.php M libraries/classes/IndexColumn.php M libraries/classes/InternalRelations.php M libraries/classes/LanguageManager.php M libraries/classes/ListAbstract.php M libraries/classes/Message.php M libraries/classes/Navigation/NavigationTree.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Navigation/Nodes/NodeDatabase.php M libraries/classes/Navigation/Nodes/NodeTable.php M libraries/classes/Normalization.php M libraries/classes/OutputBuffering.php M libraries/classes/Pdf.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/AuthenticationPluginFactory.php M libraries/classes/Plugins/Export/ExportCodegen.php M libraries/classes/Plugins/Export/ExportJson.php M libraries/classes/Plugins/Export/ExportPdf.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/ExportXml.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Export/Helpers/TableProperty.php M libraries/classes/Plugins/ExportPlugin.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Plugins/Import/ImportMediawiki.php M libraries/classes/Plugins/Import/ImportShp.php M libraries/classes/Plugins/Schema/Dia/DiaRelationSchema.php M libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php M libraries/classes/Plugins/Schema/Dia/TableStatsDia.php M libraries/classes/Plugins/Schema/Eps/Eps.php M libraries/classes/Plugins/Schema/Eps/EpsRelationSchema.php M libraries/classes/Plugins/Schema/Eps/TableStatsEps.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/TableStatsPdf.php M libraries/classes/Plugins/Schema/RelationStats.php M libraries/classes/Plugins/Schema/Svg/Svg.php M libraries/classes/Plugins/Schema/Svg/SvgRelationSchema.php M libraries/classes/Plugins/Schema/Svg/TableStatsSvg.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/classes/Plugins/TwoFactor/Application.php M libraries/classes/Plugins/TwoFactor/Invalid.php M libraries/classes/Plugins/TwoFactor/Key.php M libraries/classes/Plugins/TwoFactor/Simple.php M libraries/classes/Plugins/TwoFactor/WebAuthn.php M libraries/classes/Plugins/TwoFactorPlugin.php M libraries/classes/Providers/ServerVariables/ServerVariablesProvider.php M libraries/classes/Query/Cache.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/ReplicationInfo.php M libraries/classes/ResponseRenderer.php M libraries/classes/SavedSearches.php M libraries/classes/Scripts.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/Status/Data.php M libraries/classes/Server/SysInfo/WindowsNt.php M libraries/classes/Sql.php M libraries/classes/StatementInfo.php M libraries/classes/StorageEngine.php M libraries/classes/Table.php M libraries/classes/Table/Maintenance/Message.php M libraries/classes/Template.php M libraries/classes/Theme.php M libraries/classes/ThemeManager.php M libraries/classes/Tracker.php M libraries/classes/TwoFactor.php M libraries/classes/Types.php M libraries/classes/UserPreferences.php M libraries/classes/Util.php M libraries/classes/Utils/HttpRequest.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Navigation/Nodes/NodeColumnContainerTest.php M test/classes/Navigation/Nodes/NodeColumnTest.php M test/classes/Navigation/Nodes/NodeDatabaseTest.php M test/classes/Navigation/Nodes/NodeEventContainerTest.php M test/classes/Navigation/Nodes/NodeEventTest.php M test/classes/Navigation/Nodes/NodeFunctionContainerTest.php M test/classes/Navigation/Nodes/NodeFunctionTest.php M test/classes/Navigation/Nodes/NodeIndexContainerTest.php M test/classes/Navigation/Nodes/NodeIndexTest.php M test/classes/Navigation/Nodes/NodeProcedureContainerTest.php M test/classes/Navigation/Nodes/NodeProcedureTest.php M test/classes/Navigation/Nodes/NodeTableContainerTest.php M test/classes/Navigation/Nodes/NodeTableTest.php M test/classes/Navigation/Nodes/NodeTriggerContainerTest.php M test/classes/Navigation/Nodes/NodeTriggerTest.php M test/classes/Navigation/Nodes/NodeViewContainerTest.php M test/classes/Navigation/Nodes/NodeViewTest.php Log Message: ----------- Add native property types (#18143) * Add native property types Includes TypeHints.UnionTypeHintFormat Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Set some default values for properties Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Format and promote properties Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove redundant asserts Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Redundant cast Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * $tmanager->theme is never null Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Redundant variable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Fix empty on $statementInfo bool Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Redundant casts Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Redundant issets Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * getPacked() returns nullable string Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Redundant if Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * $this->content can be null Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Simplify ThemeManager::getInstance() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Use isset for checking if property is initialized Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Use nullable instead of uninitialized property Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * password is no longer nullable I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update baselines Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * $same_wide_width param can be float or int Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update Message.php Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Cast Sub_part to int Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Fix one line doc comments Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> --------- Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>