[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 47d9ad: Remove always false $_error

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 47d9ad9b230029fa6de4d291701fc1f2e8a82807 https://github.com/phpmyadmin/phpmyadmin/commit/47d9ad9b230029fa6de4d291701… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/Database/OperationsController.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove always false $_error Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 99f37f4b7b3338b307e5272173baf75b6818adec https://github.com/phpmyadmin/phpmyadmin/commit/99f37f4b7b3338b307e5272173b… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/View/CreateController.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove redundant is_array check It's always array because of `if (empty($view['name']))` check Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 29a055b497ccf676bfc53170feef2a50e128f4d8 https://github.com/phpmyadmin/phpmyadmin/commit/29a055b497ccf676bfc53170fee… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Query/Utilities.php Log Message: ----------- Remove redundant cast during concat Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8d06fda694e906b7dd263bf92ae7e28eb01a515b https://github.com/phpmyadmin/phpmyadmin/commit/8d06fda694e906b7dd263bf92ae… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/VersionInformation.php Log Message: ----------- Remove redundant operations These are noop anyway. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8d7e3e2229a20afbb4ff3ebb5d4eec8bb5e9565e https://github.com/phpmyadmin/phpmyadmin/commit/8d7e3e2229a20afbb4ff3ebb5d4… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Plugins/Export/ExportCsv.php Log Message: ----------- Simplified switch Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9e795e27a137ddf983c32da2032d35ab88750084 https://github.com/phpmyadmin/phpmyadmin/commit/9e795e27a137ddf983c32da2032… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Config/Form.php M libraries/classes/Config/FormDisplay.php Log Message: ----------- Remove temporary variable $cf Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1c51769b322ed8fbf86c0273c49faf2e5199b059 https://github.com/phpmyadmin/phpmyadmin/commit/1c51769b322ed8fbf86c0273c49… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/Table/FindReplaceController.php M psalm-baseline.xml Log Message: ----------- Simplify for statement into foreach Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: f1742824424de887b880611b09cab741d3aaa4a2 https://github.com/phpmyadmin/phpmyadmin/commit/f1742824424de887b880611b09c… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/Table/ZoomSearchController.php Log Message: ----------- Remove temporary var $column_names Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 7cc0fbcf56eb59c97fcc72885ff762bdacd1c6dd https://github.com/phpmyadmin/phpmyadmin/commit/7cc0fbcf56eb59c97fcc72885ff… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Database/Qbe.php M psalm-baseline.xml Log Message: ----------- Fix nullable arrays that should not be nullable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 59ba203280be2299feebc304c60f08376e5850a0 https://github.com/phpmyadmin/phpmyadmin/commit/59ba203280be2299feebc304c60… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Database/Qbe.php M psalm-baseline.xml Log Message: ----------- Remove invalid usages of htmlspecialchars() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: ce0ee04406a3ef306cdc17850e813bf2e89a5ec5 https://github.com/phpmyadmin/phpmyadmin/commit/ce0ee04406a3ef306cdc17850e8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php Log Message: ----------- Remove temporary variables Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: e64bbe292621363e637255b7846cd4c597d4c5ad https://github.com/phpmyadmin/phpmyadmin/commit/e64bbe292621363e637255b7846… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Setup/Index.php M psalm-baseline.xml Log Message: ----------- Remove temporary var $releases Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0ae05160844ea7a8b968567b594fb57a7c402f73 https://github.com/phpmyadmin/phpmyadmin/commit/0ae05160844ea7a8b968567b594… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Table.php M psalm-baseline.xml Log Message: ----------- Refactor Table::countRecords() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1bb0e830c04e76e0ec29806d3fe905a4eca610aa https://github.com/phpmyadmin/phpmyadmin/commit/1bb0e830c04e76e0ec29806d3fe… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Table.php Log Message: ----------- Remove temporary variables from Table Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0f1b6ec51d873b50a8c8624b9e7355d05e4faa55 https://github.com/phpmyadmin/phpmyadmin/commit/0f1b6ec51d873b50a8c8624b9e7… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/TwoFactor.php Log Message: ----------- Remove temporary $backend var Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 08a27b8b7e983a02650679216738ca2f7a85d285 https://github.com/phpmyadmin/phpmyadmin/commit/08a27b8b7e983a0265067921673… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-14 (Wed, 12 December 2022) -03:00 Changed paths: M libraries/classes/Config/Form.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Database/Qbe.php M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php M libraries/classes/Plugins/Export/ExportCsv.php M libraries/classes/Query/Utilities.php M libraries/classes/Setup/Index.php M libraries/classes/Table.php M libraries/classes/TwoFactor.php M libraries/classes/VersionInformation.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Merge pull request #17959 from kamil-tekiela/various-refactorings Various refactorings