[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 747941: Move $returnToSqlQuery out of the method

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 747941ece1437a1e7cf159017c02a1e1e4125ddf https://github.com/phpmyadmin/phpmyadmin/commit/747941ece1437a1e7cf159017c0… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Move $returnToSqlQuery out of the method Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 62459b33e5f89a9c502edd29974205276303b5b5 https://github.com/phpmyadmin/phpmyadmin/commit/62459b33e5f89a9c502edd29974… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Change RW param into a private property Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a8070b5498994c994974cf0b3efee9b148aac272 https://github.com/phpmyadmin/phpmyadmin/commit/a8070b5498994c994974cf0b3ef… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php M test/classes/Plugins/Transformations/TransformationPluginsTest.php Log Message: ----------- $tabindexForValue was always 0 Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 7f05587905c97cc58e33d96a14a111c70cd1eba3 https://github.com/phpmyadmin/phpmyadmin/commit/7f05587905c97cc58e33d96a14a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml Log Message: ----------- Remove method_exists Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 269535a7a57da4a1d16e5c04083ffa7d21fb1cf1 https://github.com/phpmyadmin/phpmyadmin/commit/269535a7a57da4a1d16e5c04083… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Change $tabindex into a private property Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0032b489f359b6107cd85b22f3de928807c4dc4c https://github.com/phpmyadmin/phpmyadmin/commit/0032b489f359b6107cd85b22f3d… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M test/classes/InsertEditTest.php Log Message: ----------- Merge $tabindex and $idindex into $fieldIndex Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1e14d588a7a62093387ee47397a4c10fb911c537 https://github.com/phpmyadmin/phpmyadmin/commit/1e14d588a7a62093387ee47397a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Replace ternary with boolean condition Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: b2357568a1aead75f59909e4af25d1e1db773f36 https://github.com/phpmyadmin/phpmyadmin/commit/b2357568a1aead75f59909e4af2… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon Log Message: ----------- Use str_ends_with and str_starts_with Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: bfe1f4facf526f0baef23151c5f9526f82a4ab48 https://github.com/phpmyadmin/phpmyadmin/commit/bfe1f4facf526f0baef23151c5f… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php Log Message: ----------- Remove redundant argument Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9a8fec903f8d8995269a2801f0a651dcfdd89a8a https://github.com/phpmyadmin/phpmyadmin/commit/9a8fec903f8d8995269a2801f0a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml Log Message: ----------- Replace escapeString with quoteString Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: c3701e3fea6d48e5383b71582c8eda93a10f92d1 https://github.com/phpmyadmin/phpmyadmin/commit/c3701e3fea6d48e5383b71582c8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Remove no longer needed @psalm-suppress Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 39035f91f974b3980f0f25c75129f1657c7f6905 https://github.com/phpmyadmin/phpmyadmin/commit/39035f91f974b3980f0f25c7512… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Remove strlen Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9124c19539e448a2f9c212516178e97cc16f5d57 https://github.com/phpmyadmin/phpmyadmin/commit/9124c19539e448a2f9c21251617… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Remove $GLOBALS['columns_cnt'] Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: fbb185e7a912774319ae22a54dad6fe83f1b41bc https://github.com/phpmyadmin/phpmyadmin/commit/fbb185e7a912774319ae22a54da… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove globals Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: ae5b5a1a865d7d6f77806bc85cde46cdebdf93df https://github.com/phpmyadmin/phpmyadmin/commit/ae5b5a1a865d7d6f77806bc85cd… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Remove $jsvkey and $vkey Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 36481a0dcab96afed7f19efdc047cfa038f21582 https://github.com/phpmyadmin/phpmyadmin/commit/36481a0dcab96afed7f19efdc04… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php Log Message: ----------- Change if into its short form Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a01eefc4c2103811b99e9ce0ca80031e5ea653a7 https://github.com/phpmyadmin/phpmyadmin/commit/a01eefc4c2103811b99e9ce0ca8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Remove $timestampSeen which was always false Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 103ada16b59c32a700957667851437b159d70d64 https://github.com/phpmyadmin/phpmyadmin/commit/103ada16b59c32a700957667851… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-24 (Mon, 04 April 2023) -03:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php M test/classes/Plugins/Transformations/TransformationPluginsTest.php Log Message: ----------- Merge pull request #18366 from kamil-tekiela/InsertEdit-refactoring2 InsertEdit refactoring - part 2