[phpmyadmin/phpmyadmin] 8d8ece: Remove redundant empty()

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 8d8eced45273a816d973e94ec335a858d94b2d69 https://github.com/phpmyadmin/phpmyadmin/commit/8d8eced45273a816d973e94ec335... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2022-10-17 (Mon, 10 October 2022) +01:00 Changed paths: M libraries/classes/Font.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove redundant empty() Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: 2d3c4bf74966f8fe93defe62e35bea4c1f9030ff https://github.com/phpmyadmin/phpmyadmin/commit/2d3c4bf74966f8fe93defe62e35b... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2022-10-17 (Mon, 10 October 2022) +01:00 Changed paths: M libraries/classes/Display/Results.php Log Message: ----------- Minor code simplifications Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: fd5c96e250375dedcd1a94098a669e7d283c0c41 https://github.com/phpmyadmin/phpmyadmin/commit/fd5c96e250375dedcd1a94098a66... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2022-10-17 (Mon, 10 October 2022) +01:00 Changed paths: M libraries/classes/Export.php Log Message: ----------- This should only check for empty string Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: 53b832211c395679849fad823568df1b1f38c813 https://github.com/phpmyadmin/phpmyadmin/commit/53b832211c395679849fad823568... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2022-10-17 (Mon, 10 October 2022) +01:00 Changed paths: M libraries/classes/Export.php Log Message: ----------- Make the condition clearer Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: 1e7997b76182fee68b7cb8ff56bd551f29096708 https://github.com/phpmyadmin/phpmyadmin/commit/1e7997b76182fee68b7cb8ff56bd... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2022-10-17 (Mon, 10 October 2022) +01:00 Changed paths: M libraries/classes/Export.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Plugins/Export/ExportPdfTest.php Log Message: ----------- Set property type to string It must be string as it's used only in string context. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: 32d93281bbb81ce62dd43a97622a863f5e91b585 https://github.com/phpmyadmin/phpmyadmin/commit/32d93281bbb81ce62dd43a97622a... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2022-10-17 (Mon, 10 October 2022) +01:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Export.php Log Message: ----------- Make alias merging cleaner No useless globals, no overwriting of the same value. The values seem to always be string|null so let's check explicitly for that. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: c76bb77b3c6a9f9cb8321f6527d0ff844c497b2f https://github.com/phpmyadmin/phpmyadmin/commit/c76bb77b3c6a9f9cb8321f6527d0... Author: MaurĂcio Meneghini Fauth <mauricio@fauth.dev> Date: 2022-10-18 (Tue, 10 October 2022) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Display/Results.php M libraries/classes/Export.php M libraries/classes/Font.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Plugins/Export/ExportPdfTest.php Log Message: ----------- Merge pull request #17805 from kamil-tekiela/Fix-phpstan-issues3 Fix static analysis issues
participants (1)
-
Kamil Tekiela