[phpmyadmin/phpmyadmin] ba4349: Extract shared table search form logic to SearchForm
Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: ba4349f8198c4840ecac391f33ce23cb7955ceb4 https://github.com/phpmyadmin/phpmyadmin/commit/ba4349f8198c4840ecac391f33ce... Author: Kamil Tekiela <tekiela246@gmail.com> Date: 2026-11-13 (Fri, 11 November 2026) -03:00 Changed paths: A src/Table/SearchColumns.php A src/Table/SearchForm.php M app/services.php M app/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M src/Controllers/Table/SearchController.php M src/Controllers/Table/ZoomSearchController.php M tests/unit/Controllers/Table/SearchControllerTest.php M tests/unit/Controllers/Table/ZoomSearchControllerTest.php Log Message: ----------- Extract shared table search form logic to SearchForm SearchController and ZoomSearchController had identical copies of loadTableInfo() and getColumnProperties(). The column data is now a SearchColumns value object passed as a parameter instead of mutable controller properties. ZoomSearchController::changeTableInfoAction() no longer throws a TypeError when the requested field is not a column of the table. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Commit: 19f7fa8db31abf45b85b6241c1e109d6abf6962e https://github.com/phpmyadmin/phpmyadmin/commit/19f7fa8db31abf45b85b6241c1e1... Author: MaurĂcio Meneghini Fauth <mauricio@mfauth.com.br> Date: 2026-11-13 (Fri, 11 November 2026) -03:00 Changed paths: A src/Table/SearchColumns.php A src/Table/SearchForm.php M app/services.php M app/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M src/Controllers/Table/SearchController.php M src/Controllers/Table/ZoomSearchController.php M tests/unit/Controllers/Table/SearchControllerTest.php M tests/unit/Controllers/Table/ZoomSearchControllerTest.php Log Message: ----------- Merge #20586 Extract shared table search form logic to SearchForm Closes #20586 Signed-off-by: MaurĂcio Meneghini Fauth <mauricio@mfauth.com.br>
participants (1)
-
Kamil Tekiela