Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: ae625702f1a76333e39b8ee8d023d6d0ce769e8a https://github.com/phpmyadmin/phpmyadmin/commit/ae625702f1a76333e39b8ee8d023... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-10 (Fri, 05 May 2024) -03:00

Changed paths: M app/services_controllers.php M psalm-baseline.xml M src/Controllers/Setup/ShowConfigController.php M src/Routing/Routing.php M tests/unit/Routing/RoutingTest.php

Log Message: ----------- Refactor Routing::callSetupController() to use ContainerBuilder

Uses the ContainerBuilder to factory the setup controllers.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 9cac3a9bcc60b6c65ff0beaf7e077a729db73cdf https://github.com/phpmyadmin/phpmyadmin/commit/9cac3a9bcc60b6c65ff0beaf7e07... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-10 (Fri, 05 May 2024) -03:00

Changed paths: M src/Controllers/Setup/ConfigController.php M src/Controllers/Setup/FormController.php M src/Controllers/Setup/HomeController.php M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServersController.php

Log Message: ----------- Pass ServerRequest object directly to setup controllers

Instead of passing an array of parameters.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 2fe67cc85b406caadaf079525c8686ac6043ee50 https://github.com/phpmyadmin/phpmyadmin/commit/2fe67cc85b406caadaf079525c86... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-10 (Fri, 05 May 2024) -03:00

Changed paths: A src/Controllers/Setup/ServerDestroyController.php M phpstan-baseline.neon M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServersController.php

Log Message: ----------- Extract destroy action from Setup\ServersController

Extracts it into a new controller called Setup\ServerDestroyController.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 52b3ef44959127a30830b0d3e95b171fbbc0611a https://github.com/phpmyadmin/phpmyadmin/commit/52b3ef44959127a30830b0d3e95b... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-10 (Fri, 05 May 2024) -03:00

Changed paths: A src/Setup/SetupHelper.php A tests/unit/Setup/SetupHelperTest.php M phpstan-baseline.neon M psalm-baseline.xml M psalm.xml M src/Config/PageSettings.php M src/Controllers/Preferences/ExportController.php M src/Controllers/Preferences/FeaturesController.php M src/Controllers/Preferences/ImportController.php M src/Controllers/Preferences/MainPanelController.php M src/Controllers/Preferences/ManageController.php M src/Controllers/Preferences/NavigationController.php M src/Controllers/Preferences/SqlController.php M src/Controllers/Setup/AbstractController.php M src/Controllers/Setup/ConfigController.php M src/Controllers/Setup/FormController.php M src/Controllers/Setup/HomeController.php M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServerDestroyController.php M src/Controllers/Setup/ServersController.php M src/Controllers/Setup/ShowConfigController.php M src/Controllers/Setup/ValidateController.php M src/Http/Middleware/SetupPageRedirection.php M tests/unit/Config/ServerConfigChecksTest.php

Log Message: ----------- Remove Config\ConfigFile global variables

- Removes the 'cf' and 'ConfigFile' global variables. - Extracts the ConfigFile creation from SetupPageRedirection middleware and moves it to the Setup\SetupHelper class.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 32447c6f72080d030d001f9a288467f90be75a44 https://github.com/phpmyadmin/phpmyadmin/commit/32447c6f72080d030d001f9a2884... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-10 (Fri, 05 May 2024) -03:00

Changed paths: M src/Controllers/Setup/ConfigController.php M src/Controllers/Setup/FormController.php M src/Controllers/Setup/HomeController.php M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServerDestroyController.php M src/Controllers/Setup/ServersController.php M src/Setup/SetupHelper.php M tests/unit/Setup/SetupHelperTest.php D src/Controllers/Setup/AbstractController.php

Log Message: ----------- Remove Controllers\Setup\AbstractController class

Extracts AbstractController::getPages into SetupHelper class.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 0a681ea9ed7dc04701746012636aa20477211105 https://github.com/phpmyadmin/phpmyadmin/commit/0a681ea9ed7dc04701746012636a... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-11 (Sat, 05 May 2024) -03:00

Changed paths: M app/services_controllers.php M src/Controllers/Setup/ConfigController.php M src/Controllers/Setup/FormController.php M src/Controllers/Setup/HomeController.php M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServerDestroyController.php M src/Controllers/Setup/ServersController.php

Log Message: ----------- Make all setup controllers implement InvocableController

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 126ac3ac5662ed3171ef3646636348fad3f8e952 https://github.com/phpmyadmin/phpmyadmin/commit/126ac3ac5662ed3171ef36466363... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-11 (Sat, 05 May 2024) -03:00

Changed paths: M app/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M src/Controllers/Setup/ConfigController.php M src/Controllers/Setup/FormController.php M src/Controllers/Setup/HomeController.php M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServerDestroyController.php M src/Controllers/Setup/ServersController.php M src/Controllers/Setup/ShowConfigController.php M src/Controllers/Setup/ValidateController.php

Log Message: ----------- Move check if setup is enabled to each setup controller

Removes it from the Setup\MainController as it will be removed in the future.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: de7572b9145a5c21b3bd9e150fb2dce39343fcde https://github.com/phpmyadmin/phpmyadmin/commit/de7572b9145a5c21b3bd9e150fb2... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-11 (Sat, 05 May 2024) -03:00

Changed paths: M psalm-baseline.xml M src/Controllers/Setup/FormController.php M src/Controllers/Setup/ServersController.php D src/Setup/FormProcessing.php D tests/unit/Setup/FormProcessingTest.php

Log Message: ----------- Inline and remove the Setup\FormProcessing class

This helps with the response handling.

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: c7963eab22df14866efd6af46126a1d0f8958238 https://github.com/phpmyadmin/phpmyadmin/commit/c7963eab22df14866efd6af46126... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-11 (Sat, 05 May 2024) -03:00

Changed paths: M app/services_controllers.php M src/Controllers/Setup/ShowConfigController.php

Log Message: ----------- Remove ResponseRenderer::disable from Setup\ShowConfigController

Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev

Commit: 510e442593af5d4702bbb46cdb45ad51f3a8a9d3 https://github.com/phpmyadmin/phpmyadmin/commit/510e442593af5d4702bbb46cdb45... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2024-05-13 (Mon, 05 May 2024) -03:00

Changed paths: A src/Controllers/Setup/ServerDestroyController.php A src/Setup/SetupHelper.php A tests/unit/Setup/SetupHelperTest.php M app/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M psalm.xml M src/Config/PageSettings.php M src/Controllers/Preferences/ExportController.php M src/Controllers/Preferences/FeaturesController.php M src/Controllers/Preferences/ImportController.php M src/Controllers/Preferences/MainPanelController.php M src/Controllers/Preferences/ManageController.php M src/Controllers/Preferences/NavigationController.php M src/Controllers/Preferences/SqlController.php M src/Controllers/Setup/ConfigController.php M src/Controllers/Setup/FormController.php M src/Controllers/Setup/HomeController.php M src/Controllers/Setup/MainController.php M src/Controllers/Setup/ServersController.php M src/Controllers/Setup/ShowConfigController.php M src/Controllers/Setup/ValidateController.php M src/Http/Middleware/SetupPageRedirection.php M src/Routing/Routing.php M tests/unit/Config/ServerConfigChecksTest.php M tests/unit/Routing/RoutingTest.php D src/Controllers/Setup/AbstractController.php D src/Setup/FormProcessing.php D tests/unit/Setup/FormProcessingTest.php

Log Message: ----------- Merge pull request #19156 from MauricioFauth/setup-controllers

Refactor setup controllers to implement InvocableController