[Phpmyadmin-devel] to delay or not to delay ?

[Olivier M.]

On Mon, Aug 27, 2001 at 11:40:06PM +0200, Olivier M. wrote:
> On Mon, Aug 27, 2001 at 11:24:33PM +0200, Olivier M. wrote:
> > Voila, that's what I have in mind currently :)  Will try to check
> > that NOW() problem tonight or tomorrow, and make some more tests.
> > And if I have your ok (with Loic and others here), we
> > could release it tomorrow (on tuesday), and see what happens... 
> 
> mmm, the problem seems to be worse that I first thought: seems
> that no funtion at all works when the data field is not empty.
> quite annoying to encrypt a password... 

Correction: "when the data field is not empty and the data 
field not changed".


Ok, found the problem reason: Seems to be related to the new 
"fields_prev[]" variable... :

        // No change for this column -> next column
        if (isset($fields_prev) && isset($fields_prev[urlencode($key)])
            && ("'" . sql_addslashes(urldecode($fields_prev[urlencode($key)])) . "'" == $val)) {
            continue;
        }

that doesn't check if the function is set... not good! Replaced this part
by:

        // No change for this column -> next column
        if (isset($fields_prev) && isset($fields_prev[urlencode($key)]) && !empty($funcs[$key])
            && ("'" . sql_addslashes(urldecode($fields_prev[urlencode($key)])) . "'" == $val)) {
            continue;
        }

And it seems to be ok now. If the one who made that (loic ? :) could
check if it is ok, that would be nice thanks. 


Btw, what is this $fields_prev[] information for ? (beside doubling
the page size). In the case of an UPDATE in a table without id field ? 
I see that in the changelog:
2001-08-15  Loïc Chapeaux  <lolo at phpheaven.net>
       [...]
        * tbl_change.php3; tbl_replace.php3; lang/*: Fixed bugs #444354 (Various
          backslash problems), #450906 (Disappearing + in data | 2.2.0rc4), #450374
          (RC4: + becomes space) and the one with binary data reported by Steve in
          the mailing-list.
but don't see exactely what is the fields_prev for ? (which bug ? :).


Regards,
Olivier
-- 
_________________________________________________________________
 Olivier Mueller - om at 8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch  -  http://webmail.omnis.ch