[Phpmyadmin-devel] 2.2.3: any objections?

[Olivier M.]

On Sun, Jan 06, 2002 at 10:55:05AM -0500, Marc Delisle wrote:
> With 3515 downloads and only a small typo reported, 2.2.3-rc1 seems
> stable enough.
> I would like to release it today: you know that other
> patches/improvements are waiting in the queue :)

Ok for me :)  I just got this mail a few minutes before: if you think
you can add it in this release, please do, and otherwise I'll do it
next time (I'm currently not on my devel system at home):

It seems to be a small but usefull thing (select all). But don't know
if it will work with all browsers...  

---------------------
Subject: phpMyAdmin changes
From: Joachim Fornallaz <joachim.fornallaz at access.unizh.ch>
Date: Sun, 6 Jan 2002 16:40:04 +0100

Salut Oliver

Bonne année!

Dis donc, j'ai ajouté un petit truc a phpMyAdmin. Comment
intégrer ca au projet?
Comment devenir developer de phpmyadmin sur sf.net?
C'est peut-etre plus simple si tu le fais, j'ai pas l'impression
que je vais faire grand chose a l'avenir...

dans db_details.php:
====================

<a href="#"
onClick="javascript:setSelectOptions('db_dump','table_select[]','true')"><?php
echo $strSelectAll; ?></a>

juste en dessous de
    
        <input type="radio" name="what" value="structure" checked="checked" />
        <?php echo $strStrucOnly; ?><br />
        <input type="radio" name="what" value="data" />
        <?php echo $strStrucData; ?><br />
        <input type="radio" name="what" value="dataonly" />
        <?php echo $strDataOnly . "\n"; ?><br />

dans functions.js:
==================
  
/** 
  * Checks/unchecks all options of a <select> element
  *
  * @param   string   the form name
  * @param   string   the element name
  * @param   boolean  whether to check or to uncheck the element
  * 
  * @return  boolean  always true
  */
function setSelectOptions(the_form, the_select, do_check)
{
        var selectObject = document.forms[the_form].elements[the_select];
        var selectCount  = selectObject.length;
        var selectObject = document.forms[the_form].elements[the_select];
        var selectCount  = selectObject.length;

        for (var i = 0; i < selectCount; i++) {
                selectObject.options[i].selected = do_check;
        } // end for

        return true;
} // end of the 'setSelectOptions()' function

et pour finir:
==============

[localhost:Documents/phpmyadmin/lang] jfornall% ./add_message.sh
'$strSelectAll' 'Select All'

---------------------

Bon dimanche,
Olivier

PS: beware: SF.net is supposed to be down for maintenance 
    the whole day today (us-time). 
-- 
_________________________________________________________________
 Olivier Mueller - om at 8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch  -  http://webmail.omnis.ch