[Phpmyadmin-devel] Re: 2.3.0-rc1 tomorrow?

[Robin Johnson]

On Wed, 19 Jun 2002, Rabus wrote:

> ----- Original Message -----
> From: "Robin Johnson" <robbat2 at fermi.orbis-terrarum.net>
>
>
> > > Furthermore, the backwards compatibility code for old config files does
> not
> > > seem to work correctly, I'll work on a better one tomorrow (CET).
> > > Let's wait a one ore two more days with RC 1.
> > What about the conversion script I wrote to convert the old format to the
> > new format ?
> Well, the funny thing is:
> If someone used your script, he'd get more problems than hed had before :o)
> The import code is only executed if the $cfg array doesn't exist. So
> currently you can only convert v1.80 without problems with your script.
> But I'll work on that, too.
Actually, I tested it out, and found that the raw v1.80 configuration file
causes MORE problems if it isn't converted using the script.

At least when you convert it with the script the errors it gives you are
more reasonable.

If you don't convert it, and let the import code try to do it instead, you
get this horrible purple page that keeps complaining about
$cfg['PmaAbsoluteUri'].

On my mode, it actually shows this set of warnings:
Notice: Undefined index: AllowAnywhereRecoding in
/home/robbat2/cvs/phpMyAdmin/libraries/charset_conversion.lib.php3 on line
16

Notice: Undefined index: AllowDeny in
/home/robbat2/cvs/phpMyAdmin/libraries/common.lib.php3 on line 586

Notice: Undefined index: AllowAnywhereRecoding in
/home/robbat2/cvs/phpMyAdmin/libraries/charset_conversion.lib.php3 on line
115

Notice: Undefined index: AllowAnywhereRecoding in
/home/robbat2/cvs/phpMyAdmin/libraries/charset_conversion.lib.php3 on line
51

Notice: Undefined index: AllowAnywhereRecoding in
/home/robbat2/cvs/phpMyAdmin/libraries/charset_conversion.lib.php3 on line
115

Notice: Undefined index: AllowAnywhereRecoding in
/home/robbat2/cvs/phpMyAdmin/libraries/charset_conversion.lib.php3 on line
115

Notice: Undefined index: AllowAnywhereRecoding in
/home/robbat2/cvs/phpMyAdmin/libraries/charset_conversion.lib.php3 on line
51

I've hunted down all of these fragments for now
and put a isset() statement in front of them.

PMA actually now WORKS better with an old configuration file that has just
been passed thru the convertor. Sure, there are errors sprouting
everywhere because of unset configuration variables, but they aren't
critical errors from what I can see.

If somebody spared 30 minutes, you could probably hunt down all of the
other Notice errors like this.

I'll sit down and do it tommorow morning my time, as I think a little bit
of coding the main system properly is better than trying to always update
the config_import backwards compatibility stuff.

-- 
Robin Hugh Johnson
E-Mail     : robbat2 at orbis-terrarum.net
Home Page  : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ#       : 30269588 or 41961639