[Phpmyadmin-devel] Problems with Garvin's Patches

[Rabus]

Hi Garvin & list,

-----Original Message-----
From: Garvin Hicking
>
> I will add a code to "upgrade" the comment-table structure,
> if the fields are missing. Or is emitting a red warning on
> the start page a better way?

I disagree with that because you cannot expect the user to have the
privileges he needs to change the table structure. Imho, the best
solution would be to modify the code that checks the status of the
relational tables. Furthermore, PMA_mysqlDie() shouldn't be called if
the query fails: In this case, your feature should be disabled, instead.

Nevertheless, you should documentate the new configuration directives
and table structure.

>
> > About you query box:
> > It appears a little large to me. Imho, we should only have the
> > <textarea> and the submit button there, nothing else.
>
> I can make the query history configurable, but I definitely
> want to have it.

Sorry, I did not notice the history feature at first look. Of course I
don't want to drop it, either!

Happy fixing :o)
Regards,

Alexander M. Turek
<alex at bugfixes.info>

+-----------------------------+
| The phpMyAdmin Project      |
| http://www.phpmyadmin.net   |
| rabus at users.sourceforge.net |
+-----------------------------+
| [bugfixes.info]             |
| http://www.bugfixes.info    |
| rabus at bugfixes.info         |
+-----------------------------+