[Phpmyadmin-devel] BugFix question - Bug #641765

Marc Delisle delislma at CollegeSherbrooke.qc.ca
Mon Jan 13 07:49:05 CET 2003


Robin Johnson wrote:

> 
> Looking at that code, it looks like a major code-cleaning is needed
> there, because I see MySQL4 and even later parts of MySQL3.23 subetly
> failing parts of that code. It uses case-insensative regex for searching
> negating #4 above.  Furthermore that stuff can use the results of the
> SQL parser for a nice speed improvement (through replacing the slow
> eregi), and have the same results.
> 
> I'll go and rewrite that code to use the SQP results instead.  It seems
> to be lines 48, 92, 222, 239-296, 379. Any more than you can point out ?
> 
> 

For sql.php3, this is complete.

But *sigh* there is also libraries/display_tbl.lib.php3 (and others, I am sure).

Marc





More information about the Developers mailing list