[Phpmyadmin-devel] Spaces/Label cleanup
Marc Delisle
DelislMa at collegesherbrooke.qc.ca
Thu Sep 16 06:56:00 CEST 2004
Garvin Hicking wrote:
> Hi!
>
> As proposed in Bugreport #1010752 I took the time to cleanup our general code
> style regarding labels and spaces.
>
> I removed any 'option : value' extra spaces to now read 'option: value'. And I
> removed the linebreak (causing additional spacing) in front of every <label> tag
> (only for radio/checkboxes. There still is spacing for selects and textareas,
> where extra spacing IMHO increases readability).
>
> There are a couple of occasions, where label/input fields are seperated because
> they're in differend td's of a table. I did not correct those places, as
> enhanced spacing is usually needed there (see privileges).
>
> I also cleaned up some other minor code/indenting/spacing issues, and I'd like
> to commit the patch to the upcoming HEAD for 2.6.1.
>
> Opinions?
The 2.6.0 branch should open on Sunday with the release, so HEAD will
become for 2.6.1, then you can merge. I would prefer to wait until
Sunday, to avoid merging last-minute fixes to both branches.
Thanks,
Marc
>
> Regards
> Garvin.
>
More information about the Developers
mailing list