[Phpmyadmin-devel] Re: [Phpmyadmin-cvs] CVS: phpMyAdmin/libraries/dbi

[Marc Delisle]

Sebastian Mendel a écrit :
> Marc Delisle schrieb:
> 
>> Sebastian Mendel a écrit :
>>
>>> Marc Delisle schrieb:
>>>
>>>> Sebastian Mendel a écrit :
>>>>
>>>>> Marc Delisle schrieb:
>>>>>
>>>>>> Sebastian Mendel a écrit :
>>>>>>
>>>>>>> Marc Delisle schrieb:
>>>>>>>
>>>>>>>> Sebastian Mendel a écrit :
>>>>>>>>
>>>>>>>>> Update of /cvsroot/phpmyadmin/phpMyAdmin/libraries/dbi
>>>>>>>>> In directory 
>>>>>>>>> sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31315/libraries/dbi
>>>>>>>>>
>>>>>>>>> Modified Files:
>>>>>>>>>     mysqli.dbi.lib.php Log Message:
>>>>>>>>> - make use of MYSQLI_* constants
>>>>>>>>
>>>>>>>>
>>>>>>>> Sebastian,
>>>>>>>> I knew about the constants but there was a problem with them, 
>>>>>>>> can't remember exactly for the moment. Maybe some missing values 
>>>>>>>> or wrong values. Did you test the use of constants here?
>>>>>>>
>>>>>>>
>>>>>>> tested, found no problems
>>>>>>
>>>>>>
>>>>>> In HEAD:
>>>>>> Notice: Use of undefined constant MYSQLI_BINARY_FLAG - assumed 
>>>>>> 'MYSQLI_BINARY_FLAG' in 
>>>>>> /phpMyAdmin-HEAD/libraries/dbi/mysqli.dbi.lib.php on line 465
>>>>>>
>>>>>> PHP 5.1.2
>>>>>> MySQL 5.0.18
>>>>>>
>>>>>> To reproduce:
>>>>>> On main page, click "Show processes", then click our Refresh link.
>>>>>
>>>>>
>>>>> cannot reproduce
>>>>>
>>>>> with same as above and Windows, mysql client 5.0.18
>>>>>
>>>>> whats your
>>>>> mysql client libary version?
>>>>> os?
>>>>
>>>>
>>>> MySQL client library is 4.1.12.
>>>> Server OS is Linux.
>>>>
>>>> Note that I still have the bug when connecting with mysqli to a 
>>>> MySQL 4.1.13 server.
>>>>
>>>> The bug also happens when browsing any table. Does your setup 
>>>> display notice errors?
>>>
>>>
>>> no errors at all
>>>
>>> MYSQLI_BINARY_FLAG is defined!
>>>
>>> seems to be a bug with older client libs
>>
>>
>> So you are saying that having a 4.1.12 client lib is too old for 
>> connecting to a MySQL 4.1.13 server? Well I don't get your point, and 
>> besides, we are going to have a lot of complaints about this.
> 
> 
> of course we/i should address this
> but its a bug in the client lib, independent from server version
> the client lib does not export BINARY_FLAG to MYSQLI_BINARY_FLAG
> 
> 

This flag is not even listed on
http://ca3.php.net/mysqli

Anyway I suggest to do this:

if (!defined('MYSQLI_BINARY_FLAG')) {
    define('MYSQLI_BINARY_FLAG', 128);
}