[Phpmyadmin-devel] Some useless code in PMA_fatalError

[Marc Delisle]

Piotr Przybylski a écrit :
> While going through PMA code I found some useless parts in
> PMA_fatalError (core.lib.php):
> 
> 1. I don't see strError in select_lang.lib.php
>         if (isset($strError)) {
>             $GLOBALS['strError'] = $strError;
>         }

$strError may exist at this point because in select_lang.lib.php there 
is a require() that loads all the messages for the chosen language.

> 
> 2. It's already made global in select_lang.lib.php
>         if (isset($text_dir)) {
>             $GLOBALS['text_dir'] = $text_dir;
>         }
> 
> Can somebody check it?
> 
core.lib.php can be called from the /test environment