[Phpmyadmin-devel] Some useless code in PMA_fatalError
Sebastian Mendel
lists at sebastianmendel.de
Wed Jul 9 07:30:07 CEST 2008
Piotr Przybylski schrieb:
> While going through PMA code I found some useless parts in
> PMA_fatalError (core.lib.php):
>
> 1. I don't see strError in select_lang.lib.php
> if (isset($strError)) {
> $GLOBALS['strError'] = $strError;
> }
this comes from loaded language file, as Marc already wrote
>
> 2. It's already made global in select_lang.lib.php
> if (isset($text_dir)) {
> $GLOBALS['text_dir'] = $text_dir;
> }
same as above, $GLOBALS['text_dir'] in select_lang.lib.php is only the
default/fallback, the correct is defined in loaded language file
--
Sebastian Mendel
More information about the Developers
mailing list