[Phpmyadmin-devel] ready for 3.0.0 ?

[Marc Delisle]

Marc Delisle a écrit :
> Garvin Hicking a écrit :
>> Hi!
>>
>>> I see no show stopper for a 3.0.0 release. Any objections?
>> I have one issue on my system that I could not yet analyze. When I open the URL
>> without adding a "index.php" to it, PMA creates a session and then I only get
>> this error:
>>
>>
>> Fatal error: Call to a member function checkConfig() on a non-object in
>> /home/garvin/cvs/phpMyAdmin/libraries/common.inc.php on line 661
>>
>> This only goes away when I remove my cookies and make sure to call index.php and
>> not just http://blabla/phpMyAdmin/ - it then redirects to
>> https://blablaphpMyAdmin/?collation_connection=utf8_general_ci&token=3e07b65265f22399d65b53df73ab87c8&phpMyAdmin=458a26a355fed45064a1e8f74ce3b980a491331d
>>
>> I just HTTP auth, not cookie auth. I also wonder why it redirects to https://
>> without me explicitly instructing this. Also, the & should not be there, it
>> should read "&token" instead.
> 
> Already in the bug tracker:
> http://sourceforge.net/tracker/index.php?func=detail&aid=1914066&group_id=23067&atid=377408

Garvin,
1. for your error on checkConfig(), I would guess this is because of an
older config.inc.php or incompatible theme.

2. For the &, could you try with this (still with ForceSSL enabled):

Index: libraries/common.inc.php
===================================================================
--- libraries/common.inc.php    (revision 11614)
+++ libraries/common.inc.php    (copie de travail)
@@ -539,7 +539,7 @@
     PMA_sendHeaderLocation(
         preg_replace('/^http/', 'https',
             $_SESSION['PMA_Config']->get('PmaAbsoluteUri'))
-        . PMA_generate_common_url($_GET));
+        . PMA_generate_common_url($_GET, '', '&'));
     exit;
 }