[Phpmyadmin-devel] ideas / concerns / problems [about|with] user settings feature

[Michal Čihař]

Hi

Dne Tue, 28 Jul 2009 03:24:25 -0400
"Zeeshan M." <zeeshan.jp at gmail.com> napsal(a):

> I uploaded a revision for patch #
> <goog_1248753684487>2825187<https://sourceforge.net/tracker/download.php?group_id=23067&atid=377410&file_id=336915&aid=2825187>at
> sourceforge.net.

Why do you introduce syntax errors (calendar.php)?

Why do you change config defaults (libraries/config.default.php)?

Why do you duplicate lot of information in permUsrPref class (user
name, table name, database link,...)?

In server_perm_storage.php there is a huge code duplication, please
have just one piece code to handle setting the value and do not copy it
for every available option.

-- 
	Michal Čihař | http://cihar.com | http://phpmyadmin.cz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20090729/a177164c/attachment.sig>