[Phpmyadmin-devel] Martynas tree - codingstandards

[Martynas Mickevičius]

Hey, I am back on the track.

I have fixed the case problem a while ago but it did not solve the problem
completely.

I was wondering maybe it would be possible to enable all error reporting on
the http://demo.phpmyadmin.net/gsoc-blinky so that I can find where the
error is.

If this is not possible then an ability for me to tell the demo server to
fetch the latest revision from repository would be nice. This would decrease
debugging time substantially.

Martynas

On 23 June 2010 12:08, Herman van Rink <rink at initfour.nl> wrote:

> Martynas,
>
> Unfortunately the latest git version is broken for me.
> At least in libraries/chart.lib.php on line 5 you use a lower case
> filename which does not match in case-sensitive environments.
>
> Some other points:
> * Please use curly braces even in situations where they are technically
> optional. Not:
>      if (is_null($options))
>            return;
>
>    but
>
>        if (is_null($options)) {
>            return;
>        }
>
> * Please make sure you properly escape variables you print to the user.
> $sql_query in tbl_chart.php should probably have htmlspecialchars()
>    In general ... distrust any data you get from the outside.
>
>
> Most code looks OK though, nice going.
>
> --
> Met vriendelijke groet / Regards,
>
> Herman van Rink
> Initfour websolutions
>
>
>
>
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit.  See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20100706/152c587b/attachment.html>