[Phpmyadmin-devel] How to join and attach patches

Pavel Konnikov konnikov at gmail.com
Wed Mar 3 16:04:49 CET 2010

> Only the original submitter and project members van attach files to
> already open tracker artifacts.
> Adding an artifact to the patches tracker would probably be the best
> course of action.
I've add new patch in patch tracker "After import also display
uploaded filename" ID: 2962655

> Here are a few quick first remarks about the patch
> * you put the filename in a separate formfield, couldn't we use
> $import_file for this?
$import_file variable store the file name on the server instead of on
the client.

> * you indented some of the lines with a tab-character, please use 4
> spaces as is recommended by the PEAR coding standards
I've fixed it

> --
> Met vriendelijke groet / Regards,
> Herman van Rink
> Initfour websolutions

Best regards. Pavel Konnikov

More information about the Developers mailing list