[Phpmyadmin-devel] Codemirror upgrade broke my features

Rouslan Placella rouslan at placella.com
Fri Aug 19 16:35:24 CEST 2011


Yesterday Tyron brought to my attention that the editors for Routines,
Triggers and Events look quite bad now. I've tracked the issue down to
the upgrade of codemirror to version 2.12 (before/after screenshot
attached). And in particular these lines of code that were introduced in
codemirror.js (lines 775-777):

--->%---
// Needed to prevent odd wrapping/hiding of widgets placed in here.
code.style.width = "";
code.style.width = scroller.scrollWidth + "px";
--->%---

I'd like to comment these lines out, since I don't think that there is
any other way of fixing the issue. Any objections?

Rouslan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot.png
Type: image/png
Size: 32350 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110819/01eb0f92/attachment.png>


More information about the Developers mailing list