[Phpmyadmin-devel] Codemirror upgrade broke my features

Tyron Madlener tyronx at gmail.com
Fri Aug 19 16:41:19 CEST 2011


On Fri, Aug 19, 2011 at 5:35 PM, Rouslan Placella <rouslan at placella.com> wrote:
> Yesterday Tyron brought to my attention that the editors for Routines,
> Triggers and Events look quite bad now. I've tracked the issue down to
> the upgrade of codemirror to version 2.12 (before/after screenshot
> attached). And in particular these lines of code that were introduced in
> codemirror.js (lines 775-777):
>
> --->%---
> // Needed to prevent odd wrapping/hiding of widgets placed in here.
> code.style.width = "";
> code.style.width = scroller.scrollWidth + "px";
> --->%---
>
> I'd like to comment these lines out, since I don't think that there is
> any other way of fixing the issue. Any objections?
>
> Rouslan

Oh, that is awesome that you found the bug. I've had the same issues
on my code before.

Do you know what the code snippet does actually? Maybe we should ask
the original author first what it's for.

>
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>




More information about the Developers mailing list