[Phpmyadmin-devel] grid editing and newlines

[Marc Delisle]

Aris Feryanto a écrit :
> 
> On 11 Dec, 2011, at 7:37 PM, Marc Delisle <marc at infomarc.info 
> <mailto:marc at infomarc.info>> wrote:
> 
>  > Le 2011-11-14 10:58, Aris Feryanto a écrit :
>  >> Hi all,
>  >>
>  >>
>  >> On 12 Nov, 2011, at 2:29 AM, Piotr Przybylski<piotr.prz at gmail.com 
> <mailto:piotr.prz at gmail.com>>
>  >> wrote:
>  >>
>  >>> 2011/11/11 Marc Delisle<marc at infomarc.info 
> <mailto:marc at infomarc.info>>:
>  >>>> Piotr Przybylski a écrit :
>  >>>>> 2011/11/11 Marc Delisle<marc at infomarc.info 
> <mailto:marc at infomarc.info>>:
>  >>>>>> Dieter Adriaenssens a écrit :
>  >>>>>>> Kind regards, Dieter Adriaenssens. Op 11 nov. 2011 16:00
>  >>>>>>> schreef "Marc Delisle"<marc at infomarc.info 
> <mailto:marc at infomarc.info>
>  >>>>>>> <mailto:marc at infomarc.info <mailto:marc at infomarc.info>>>  het 
> volgende:
>  >>>>>>>>
>  >>>>>>>> Hi, when grid editing a TEXT column, hitting ENTER
>  >>>>>>>> transmits my change instead of inserting a new line.
>  >>>>>>>
>  >>>>>>> It makes sense that in this case a new line is added, but
>  >>>>>>> how should the entry be submitted in the database? If I'm
>  >>>>>>> not mistaken there is no submit button at the moment.
>  >>>>>> Dieter, by default, $cfg['SaveCellsAtOnce'] is set to false,
>  >>>>>> thus not showing a submit button.
>  >>>>>>
>  >>>>>> When setting it to true, a submit button appears but the
>  >>>>>> field closes as soon as ENTER is hit.
>  >>>>>>
>  >>>>>> If we want to support grid editing + newlines, a possible
>  >>>>>> solution would be to ask the user to click outside the input
>  >>>>>> field but it's less efficient.
>  >>>>>>
>  >>>>>
>  >>>>> How about ignoring Shift+ENTER for submitting? This way ENTER
>  >>>>> would submit form and Shift+ENTER would just insert a newline.
>  >>>>>
>  >>>> Yes but is Shift+Enter intuitive enough or do we need to -
>  >>>> advertise it on the page - explain it in Documentation.html
>  >>>>
>  >>>
>  >>> I've seen it used in a few places, but it's not common - some
>  >>> "Press Shift+Enter for newline" message under text field would be
>  >>> needed.
>  >>>
>  >>
>  >> Yes. I agree to use Shift+Enter and display a hint for that. I'll try
>  >> to fix this and the RTL alignment on this weekend.
>  >
>  > Hi Aris,
>  > any progress on this?
>  > 
> 
> Hi Marc,
> 
> I've added the shift+enter handling in my repo [1].
> I also added OK and Cancel button in the editing area.
> But, I haven't finished fixing the RTL alignment.
> 
> If you have some time, you may test the shift+enter and the buttons in 
> my repo.
> 
> [1] http://repo.or.cz/w/phpmyadmin/arisferyanto.git

Hi Aris,
I tested the master branch in your repo. Shift+enter works well, but I 
don't see any OK and cancel buttons.

However, in your branch (and in origin/master), grid-editing a TEXT 
column containing new lines is problematic: new lines are lost on 
entering grid-editing.

-- 
Marc Delisle
http://infomarc.info