[Phpmyadmin-devel] Better table navigation

[Tyron Madlener]

On Thu, Jul 7, 2011 at 12:23 PM, Aris Feryanto <aris_feryanto at yahoo.com> wrote:
> ----- Original Message -----
>
>> From: Tyron Madlener <tyronx at gmail.com>
>>
>> On Thu, Jul 7, 2011 at 11:21 AM, Aris Feryanto <aris_feryanto at yahoo.com>
>> wrote:
>>>  ----- Original Message -----
>>>
>>>>  From: Marc Delisle <marc at infomarc.info>
>>>>
>>>>  Le 2011-07-05 03:53, Tyron Madlener a écrit :
>>>>>   On Tue, Jul 5, 2011 at 6:53 AM, Aris Feryanto
>>>>>   <aris_feryanto at yahoo.com> wrote:
>>>>>>   Hi,
>>>>>>
>>>>>>   ----- Original Message -----
>>>>>>
>>>>>>>   From: Marc Delisle <marc at infomarc.info>
>>>>>>>
>>>>>>>   Le 2011-06-30 21:07, Aris Feryanto a écrit :
>>>>>>>>
>>>>>>>>   Btw, (just to make sure) if we really want to remove
>> the
>>>>>>>>   vertical support, it will be done in the next version
>> after
>>>>>>>>   3.5, isn't it?
>>>>>>>
>>>>>>>   I was hoping to remove it for 3.5; in fact, a quick
>> decision
>>>>>>>   about this would give clear indications to GSoC 2011
>> students (I
>>>>>>>   know it's a bit late but at least, it would help for
>> the rest
>>>>  of
>>>>>>>   GSoC 2011).
>>>>>>>
>>>>>>
>>>>>>
>>>>>>   Regarding the removal, everyone agree to remove the
>> vertical-mode
>>>>>>   support in version 3.5? If yes, can I work on this?
>>>>>>
>>>>>
>>>>>   Probably easier to ask who disagrees ;-)
>>>>
>>>>  We already know that some persons disagree.
>>>>
>>>>>
>>>>>   I'd suggest to hide the feature / disable by default  first,
>> then
>>>>>   remove it in the next version.
>>>>
>>>>  In current master, the display mode selector is now hidden by default.
>>>>
>>>>  I suggest to remove all js code that deals with special features for
>>>>  vertical display mode. For example in js/sql.js for the
>>>>  appendInlineAnchor() function, the first "if" would become
>> empty. The
>>>>  results of this would be that inline edit for rows would appear just
>> for
>>>>  horizontal display mode.
>>>>
>>>
>>>
>>>  Hi,
>>>
>>>  Since there is no objection regarding the removal of javascript support for
>> vertical mode, I'll start working on this.
>>>
>>
>> Well, as mentioned before, my suggestion would be to remove it in a
>> future version only.
>> Or is there any reason why it should be removed now?
>>
>
>
> Hi Tyron,
>
> I think the reason is like what Marc has written: "a quick decision about this would give clear indications to GSoC 2011 students", IMHO. Some of GSoC-ers may have to deal with features supporting vertical mode. The removal will give a better direction about how to implement these features. The benefit will be simpler and cleaner code.
>

Ah, alright. But from what I've seen the code for vertical and
horizontal mode is fairly separate. Is it causing much trouble to one
of the gsoc projects?

Anyway, since we can always revert any changes to the code (if
vertical mode turns out to be really needed), feel free to remove it.
Clean code is always good.

>
> --
> Aris Feryanto
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>