[Phpmyadmin-devel] PMA Icon Spritify

[Marc Delisle]

Le 2011-07-15 03:41, Tyron Madlener a écrit :
> Hi, I've got a huge patch ready. In my branch 'sprites' I have
> replaced the majority of all pma icons with sprites. This gives us the
> following advantages
> 
> - In a few tests I saw that the overall amount of GET requests now has
> been reduced by 20-33% depending on the loaded page
> - In the process I removed all width/height attributes, and instead
> moving this style related property into the stylesheet file. This will
> also allow for much greater flexibility for theme makers.
> - The code altogether is easier to read. No more theme path required
> anymore. Example:

Tyron,
about removing $cfg['ThemePath'], I have a small objection (small
because I appreciate your work but we have to think about others).

The ThemePath is configurable to allow anyone (a distro, a sysadmin) to
use a chosen directory containing themes. Can we keep this flexibility
and still use sprites?

-- 
Marc Delisle
http://infomarc.info