[Phpmyadmin-devel] zoom-search default label

[Ammar Yasir]

On Fri, Jul 15, 2011 at 7:30 PM, Marc Delisle <marc at infomarc.info> wrote:

> Le 2011-07-15 09:56, Ammar Yasir a écrit :
> > On Fri, Jul 15, 2011 at 7:19 PM, Marc Delisle <marc at infomarc.info>
> wrote:
> >
> >> Le 2011-07-14 15:39, Ammar Yasir a écrit :
> >>> On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir <ammaryasir.88 at gmail.com
> >>> wrote:
> >>>
> >>>>
> >>>>
> >>>> On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir <
> ammaryasir.88 at gmail.com
> >>> wrote:
> >>>>
> >>>>>
> >>>>>
> >>>>> On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir <ayax88 at gmail.com>
> wrote:
> >>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle <marc at infomarc.info
> >>> wrote:
> >>>>>>
> >>>>>>> Le 2011-07-11 21:26, Ammar Yasir a écrit :
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc at infomarc.info
> >>>>>>>> <mailto:marc at infomarc.info>> wrote:
> >>>>>>>>
> >>>>>>>>     Le 2011-07-09 22:59, Ammar Yasir a écrit :
> >>>>>>>>      >
> >>>>>>>>      >
> >>>>>>>>      > I've done a basic version of edit functionality. I added a
> >>>>>>> unique
> >>>>>>>>      > identifier for each row in the query result data by using
> the
> >>>>>>>>      > PMA_getUniqueCondition() from the common.lib.php file
> >>>>>>>>     (where_clause). I
> >>>>>>>>      > then generate the update query in the edit submit event
> using
> >>>>>>>>     this where
> >>>>>>>>      > clause and post it to sql.php. The return data is added to
> >> the
> >>>>>>>>      > <sqlqueryresult> div to show the query executed and the
> >>>>>>> message. The
> >>>>>>>>      > plot also updates on submit if one of the axes is updated.
> Is
> >>>>>>> my
> >>>>>>>>     logic
> >>>>>>>>      > is okay?
> >>>>>>>>      > I've pushed my work and you can try scenarios on the
> >> film_actor
> >>>>>>>>     table in
> >>>>>>>>      > the sakila database.
> >>>>>>>>
> >>>>>>>>     Ammar,
> >>>>>>>>     I tried with the film table, changing the "title" column and
> got
> >>>>>>>>     this error:
> >>>>>>>>     value is undefined at line 177 in js/tbl_zoom_plot.js.
> >>>>>>>>
> >>>>>>>> Fixed some issues and pushed it to my repo. Had to add checkboxes
> >> for
> >>>>>>>> null condition on fields (in Data point content section).
> >>>>>>>
> >>>>>>> It works fine now.
> >>>>>>> Please don't forget the issue of generating the default data label
> >> based
> >>>>>>> on the "display field".
> >>>>>>>
> >>>>>>
> >>>>> Fixed this, default label is taken from table display field.
> >>
> >> It still does not work. When I initially enter Zoom search, $zoom_submit
> >> and $inputs are not defined so $dataLabel does not receive the results
> >> of PMA_getDisplayField($db,$table).
> >>
> >> I think I misunderstood. What I am doing is that, if a user does not
> > selects a datalabel, it defaults to the display field. That works fine. I
> > guess what you are saying is that the default selected value/index should
> be
> > the display field?
>
> When a user enters zoom-search, it would be very reassuring to see that
> the default label is set to the display column (from
> PMA_getDisplayField()). Otherwise, the user who has already set this
> display column in Relation view will wonder what's going on.
>
> Yes true. Made the changes and pushed to my repo.


> --
> Marc Delisle
> http://infomarc.info
>
>
> ------------------------------------------------------------------------------
> AppSumo Presents a FREE Video for the SourceForge Community by Eric
> Ries, the creator of the Lean Startup Methodology on "Lean Startup
> Secrets Revealed." This video shows you how to validate your ideas,
> optimize your ideas and identify your business strategy.
> http://p.sf.net/sfu/appsumosfdev2dev
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110715/f68ce0c5/attachment.html>