[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Column->Change

[Marc Delisle]

Le 2011-07-21 10:53, Tyron Madlener a écrit :
> On Tue, Jul 19, 2011 at 2:45 PM, Marc Delisle <marc at infomarc.info> wrote:
>> Le 2011-07-18 21:47, Thilanka Kaushalya a écrit :
>>> Hi Marc,
>>>
>>> there are still elements with the same id, for example in my test of the
>>>> sakila database, there are two elements with id footnote_1_1.
>>>>
>>>> The source of the problem is the following. When db_structure.php is
>>>> executed, it calls PMA_showHint() which keeps track of the number of
>>>> instances for each message in a global array.
>>>>
>>>> However, when you call tbl_change.php via AJAX, the global variables are
>>>> reset and this execution is not aware of the previously recorded instances.
>>>>
>>>>
>>> Hi Marc,
>>>
>>> As Rouslan said can I remove this ID's from elements and add as classes.
>>> Since my new logic in initTooltips($div) function it get the $div parameter
>>> to define the search sub domain for footnotes elements it will not conflict
>>> with multiple elements having the same class. Thank you.
>>
>> Thilanka,
>> yes, try that.
>>
>> P.S. I suggest renaming initToolTips() to a better name like
>> PMA_convertFootnotesToTooltips().
> 
> initToolTips() was used on the status page, so that broke the status
> page on the master demo for now. I have already patched it in my repo.

Sorry, I had thought about it but afterwards forgot. I'll cherry-pick
your patch and apply it to origin/master.


-- 
Marc Delisle
http://infomarc.info