[Phpmyadmin-devel] Grid editing versus Inline edit

[Aris Feryanto]

On 23 Jul 2011, at 02:06, Marc Delisle <marc at infomarc.info> wrote:

> Le 2011-07-22 12:18, Aris Feryanto a écrit :
>> ----- Original Message -----
>> 
>>> From: Marc Delisle <marc at infomarc.info>
>>> 
>>> Le 2011-07-22 10:11, Aris Feryanto a écrit :
>>>> ----- Original Message -----
>>>>> From: Marc Delisle <marc at infomarc.info>
>>>>> 
>>>>> Le 2011-07-22 09:16, Aris Feryanto a écrit :
>>>>>> ----- Original Message -----
>>>>>>> From: Marc Delisle <marc at infomarc.info>
>>>>>>> 
>>>>>>> Hi, I just tried Aris's new feature: grid editing (or Edit 
>>>>>>> mode). A few things are not ready, for example ENUM, SET
>>>>>>> and TEXT editing; however I feel that with this, we won't
>>>>>>> need inline edit (for rows) any more.
>>>>>>> 
>>>>>> 
>>>>>> Hi Marc and all,
>>>>>> 
>>>>>> Yes, it is still not complete yet. I'm still working on
>>>>>> adding support for different data types and fixing bugs.
>>>>>> Things I've noticed:
>>>>>> 
>>>>>> - the feature still does not work well with inline edit
>>>>> 
>>>>> Don't you think that this feature should replace inline edit?
>>>> 
>>>> IMO yes, it should replace inline edit. I stated it above to
>>>> make sure everyone who want to test it know that current version
>>>> is not working well with inline edit.
>>>> 
>>>>> 
>>>>>> - there is still a problem with data transformation - make
>>>>>> grid editing available to those table cell which doesn't
>>>>>> have .inline_edit class (e.g., TEXT)
>>>>>> 
>>>>>> I also planned to add an option to turn on/off "ask before
>>>>> saving".
>>>>>> Besides these things, the UI and editing mode can be tested
>>>>>> in [0]. Any feedback or comment is really appreciated.
>>>>> 
>>>>> Saving is done by clicking outside the cell, right? But it's
>>>>> not explained, should it be?
>>>>> 
>>>>> Also, if we compare with a spreadsheet program, saving is not
>>>>> done when exiting a cell, it's done by an explicit click (for
>>>>> example on a Disk button). The user might want to change many
>>>>> columns before saving.
>>>> 
>>>> Great. I think it's good to have the feature to save all edited 
>>>> columns at once.
>>> 
>>> So you'll change the interface to avoid auto-saving after clicking 
>>> outside of the modified cell?
>> 
>> I'll try to provide these two options for the user to choose: -
>> auto-save (with/without confirmation) - save all edited cells at
>> once
> 
> Which one will be by default?

Following the nature of spreadsheet apps, "save all edited cells at once" should be the default IMO.

> 
>>>>> I'm also wondering about the "Edit mode". Why not just
>>> enter edit
>>>>> when someone clicks on data? I know that, currently, clicking
>>>>> on data produces row marking and ticks the checkbox, but this
>>>>> could be improved. After all, the most probable intention from
>>>>> a user (with a spreadsheet knowledge) clicking on data is to
>>>>> edit it.
>>>> 
>>>> When I made this "Edit mode", I was thinking about clicking data
>>>> 
>>> with
>>>> a link, for example foreign key in InnoDb table. We may expect to
>>>> go to the data associated with the foreign value when clicking
>>>> the link, don't we?
>>> 
>>> Yes. With the current way you are tracking the mouse inside a cell
>>> (and display the down arrow), edit mode is needed.
>>> 
>>> Is is possible to not have an edit mode; then the user, clicking on
>>> a data link, would follow the link, but clicking anywhere in the
>>> cell would put this cell in edit mode?
>> 
>> Yes, it is possible. I'll try it. Regarding the data link, how about
>> this: clicking everything in a cell will open the edit box + edit
>> area (area below the drop-down edit box), but if the cell contains
>> link, we provide that link in edit area to really open the link.
>> (Just like clicking on a "link" cell in Google Docs)
> 
> Good idea; even if this means an extra click, this feature (following a
> link to foreign table) is probably not used that much.
> 
> Do not forget about these:
> - the title when hovering over the link
> - the display Options (Relational key / Relational display column).

Ok, I'll look into that later.

> 
>> 
>>> 
>>> We need to find the most intuitive way of editing and I need to be 
>>> convinced that this is not by clicking.
> 

--
Aris Feryanto