[Phpmyadmin-devel] about $charset removal

Michal Čihař michal at cihar.com
Fri Jun 3 15:45:55 CEST 2011


Hi

Dne Fri, 03 Jun 2011 09:41:49 -0400
Marc Delisle <marc at infomarc.info> napsal(a):

> Michal Čihař a écrit :
> > Hi
> > 
> > Dne Fri, 03 Jun 2011 13:54:21 +0100
> > Rouslan Placella <rouslan at placella.com> napsal(a):
> > 
> >> On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
> >>> Notice in ./main.php#171
> >>> Undefined variable: charset
> >>>
> >>> Notice in ./main.php#172
> >>> Undefined variable: charset
> >>>
> >> Was this message meant to be sent to Piotr only?
> > 
> > Probably to me rather :-). Fixed in git.
> 
> Yes; so the trend is to hardcode 'utf-8' instead of this old variable?

Well it was anyway sort of hardcoded in most places for long time
(translations, MySQL connection). This was relict from time when we
offered all translations in several encodings. So I don't see need to
have variable always holding 'utf-8' :-).

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110603/fe56d04c/attachment.sig>


More information about the Developers mailing list