[Phpmyadmin-devel] about $charset removal

[Marc Delisle]

Michal Čihař a écrit :
> Hi
> 
> Dne Fri, 03 Jun 2011 09:41:49 -0400
> Marc Delisle <marc at infomarc.info> napsal(a):
> 
>> Michal Čihař a écrit :
>>> Hi
>>>
>>> Dne Fri, 03 Jun 2011 13:54:21 +0100
>>> Rouslan Placella <rouslan at placella.com> napsal(a):
>>>
>>>> On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
>>>>> Notice in ./main.php#171
>>>>> Undefined variable: charset
>>>>>
>>>>> Notice in ./main.php#172
>>>>> Undefined variable: charset
>>>>>
>>>> Was this message meant to be sent to Piotr only?
>>> Probably to me rather :-). Fixed in git.
>> Yes; so the trend is to hardcode 'utf-8' instead of this old variable?
> 
> Well it was anyway sort of hardcoded in most places for long time
> (translations, MySQL connection). This was relict from time when we
> offered all translations in several encodings. So I don't see need to
> have variable always holding 'utf-8' :-).

I was thinking about having a constant. Not sure that we'll ever need to 
change this, however.


-- 
Marc Delisle
http://infomarc.info