[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Add a new user in db-> privileges

[Marc Delisle]

Le 2011-06-04 22:29, Thilanka Kaushalya a écrit :
> Hi Marc,
> 
> 
> Works fine now. Are you done with this feature? Before I put it in
>> production, please polish your code in js/server_privileges.js:
>>
>> - remove tab characters (we use indents of four spaces)
>>
>> I'm using 4 space indentation . I checked the code but I cannot find where
>  have added tab characters.
> 
> - use spaces around operators
>>  "url.length-23" should be "url.length - 23"
>>
>>
> Okay I fixed that.
> 
> 
>> - watch proper code indentations
>>
>> - use more spaces around keywords
>>  "if(" should be "if ("
>>  "}else{" should be "} else {"
>>
>>
> Okay I fixed that.
> 
> I fixed the above issues and pushed to the repo. Please check that.
> 
> Regards,
> Thilanka.

Thanks, this feature is now part of origin/master. Please have a look at
my commit a7a20980067c9c9dc436e59129cb420d0badafa3 because this time
there were too many spaces :)


-- 
Marc Delisle
http://infomarc.info