[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Add a new user in db-> privileges

[Thilanka Kaushalya]

Hi Marc,


Works fine now. Are you done with this feature? Before I put it in
> production, please polish your code in js/server_privileges.js:
>
> - remove tab characters (we use indents of four spaces)
>
> I'm using 4 space indentation . I checked the code but I cannot find where
 have added tab characters.

- use spaces around operators
>  "url.length-23" should be "url.length - 23"
>
>
Okay I fixed that.


> - watch proper code indentations
>
> - use more spaces around keywords
>  "if(" should be "if ("
>  "}else{" should be "} else {"
>
>
Okay I fixed that.

I fixed the above issues and pushed to the repo. Please check that.

Regards,
Thilanka.


-- 
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka

Connect with me at,
      Gmail        : lgtkaushalya at gmail.com
      Twitter       : @thilanka_k
      Facebook  : Thilanka Kaushalya
      Yahoo       : lgtkaushalya at yahoo.com
      Blog          : http://coders-view.blogspot.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110605/807136b0/attachment.html>