[Phpmyadmin-devel] Hardcoded array sizes in sqlparser.data.php

Piotr Przybylski piotr.prz at gmail.com
Mon Jun 6 00:34:32 CEST 2011


2011/6/5 Marc Delisle <marc at infomarc.info>:
> Le 2011-06-04 11:33, Piotr Przybylski a écrit :
>> Hi,
>>
>> Is there any reason for hardcoding array sizes in sqlparser.data.php?
>> count()'s complexity is O(1), it just reads item count from hash table
>> which is used internally for storing arrays.
>>
>
> Good idea to go back to using count().
>

Done. Along with that, I removed also $mysql_charsets_count and
$mysql_collations_count. All were used in SQL parser, so I moved their
definition to PMA_SQP_parse.

-- 
Piotr Przybylski




More information about the Developers mailing list