[Phpmyadmin-devel] 3 patch suggestions for master

[Tyron Madlener]

On Mon, May 30, 2011 at 10:18 PM, Marc Delisle <marc at infomarc.info> wrote:
> Tyron Madlener a écrit :
>> On Mon, May 30, 2011 at 6:47 PM, Marc Delisle <marc at infomarc.info> wrote:
>>> Tyron Madlener a écrit :
>>>> Since I always have a love for details, here's 3 small suggestions
>>>> that maybe can be merged into the master branch. They are all pushed
>>>> to my fork (http://repo.or.cz/w/phpmyadmin/tyronm.git):
>>>>
>>>> - Commit a0302c666c1bf9f9715364a6301238b474aedac1
>>>> Removes timepicker.js. It is already included with the jquery ui. The
>>>> file was included only in tbl_change.php and tbl_select.php
>>> Tyron,
>>> I don't see a timepicker in jQuery UI's Datepicker. It only handles the
>>> date, not the time.
>>
>> Oh right. But it is not being used. tab_change.js uses
>> PMA_addDatepicker() from functions.js which uses $.datepicker(), not
>> $.timepicker() from what I can see.
>
> Tyron,
>
> js/jquery/timepicker.js is currently used. To prove it, rename the file
> and try to pick a time when inserting or searching on a table with a
> time column: it won't work.

Ow, now I see. I didn't check it with a DATETIME type. Commit is
reverted on my repos now. Thanks for explaining!

>
>>
>> And tbl_select.js interestingly doesn't initialize any date/timepicker
>> widget at all.
>>
>> Shall I try and implement it instead?
>
>
>
>
> --
> Marc Delisle
> http://infomarc.info
>
> ------------------------------------------------------------------------------
> vRanger cuts backup time in half-while increasing security.
> With the market-leading solution for virtual backup and recovery,
> you get blazing-fast, flexible, and affordable data protection.
> Download your free trial now.
> http://p.sf.net/sfu/quest-d2dcopy1
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>