[Phpmyadmin-devel] 3 patch suggestions for master

Michal Čihař michal at cihar.com
Tue May 31 10:51:35 CEST 2011


Hi

Dne Tue, 31 May 2011 10:43:01 +0200
Tyron Madlener <tyronx at gmail.com> napsal(a):

> One more patch suggestion:
> 
> - Commit 9385012b97b4c188618ee8658d4e7a3b9200aa5d
> The status page displays percentual and averaged numbers, which for
> very low values displays 0.0% or 0.0 which is mathematically seen
> incorrect. The supplied patch changes such values into "<0.1", or
> verbally expressed: "Smaller than the smallest value I can display".
> It's calculated with "(1/PMA_pow(10,$comma))", so its always the
> smallest displayable value.

Makes sense. But please for next time keep formatting changes in
separate commit, to ease bug finding in future (you can use some
graphical tool or git add -i to choose which hunks you want to be part
of the commit).

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110531/949a8a10/attachment.sig>


More information about the Developers mailing list