[Phpmyadmin-devel] Zoom Search

[Marc Delisle]

Ammar Yasir a écrit :

> Parts refactored are:
> - Setting titles (titles['Browse']])
> - getting fields list (getting column details)
> - setting sub-tabs (Table search and Zoom search)
> - setting table header of QBE display
> - displaying foreign data
> - search criteria input elements (HTML content generation for the input 
> elements)

Very good!

Another trick you can use: when a function returns an array, like your 
PMA_tbl_getFields(), to fill all the returned values in one statement 
you can use this syntax:

list($fields_list, $fields_type, $fields_collation, $fields_null) = 
PMA_tbl_getFields($table,$db);

>  
> 
>     In libraries/tbl_select.lib.php, please describe for each function the
>     parameters and return values; see an example in
>     libraries/server_synchronize.lib.php.
> 
>     About the syntax, please use spaces around operators. Instead of
>     $i-1
>     use
>     $i - 1

There are still a few cases of missing spaces around operators.

-- 
Marc Delisle
http://infomarc.info