[Phpmyadmin-devel] about PMA_getImage()

Rouslan Placella rouslan at placella.com
Tue Oct 4 17:56:25 CEST 2011


On Tue, 2011-10-04 at 06:13 -0400, Marc Delisle wrote:
> Rouslan,
> 
> Using is_readable() on the current theme's sprites.lib.php is costly.
> Can't we just assume that the file is there (therefore making it
> mandatory for all themes) ?

We could, but we'll lose compatibility with older themes. The idea in my
implementation was to also allow for better backwards compatibility.

I profiled the generation of the css file though XDEBUG and on my system
is_readable() seems to only take 2 uS per call, which doesn't seem like
much to me. Or am I missing something?

Rouslan





More information about the Developers mailing list