[Phpmyadmin-devel] about PMA_getImage()
marc at infomarc.info
Tue Oct 4 18:19:19 CEST 2011
Rouslan Placella a écrit :
> On Tue, 2011-10-04 at 06:13 -0400, Marc Delisle wrote:
>> Using is_readable() on the current theme's sprites.lib.php is costly.
>> Can't we just assume that the file is there (therefore making it
>> mandatory for all themes) ?
> We could, but we'll lose compatibility with older themes. The idea in my
> implementation was to also allow for better backwards compatibility.
We don't currently have compatibility with older themes; just have a
look at http://demo.phpmyadmin.net/master and try older themes.
> I profiled the generation of the css file though XDEBUG and on my system
> is_readable() seems to only take 2 uS per call, which doesn't seem like
> much to me. Or am I missing something?
Ok, then it's not as costly as I imagined.
More information about the Developers