[Phpmyadmin-devel] tbl_operation - Bug Fixing

[Thilina Buddika Abeyrathna]

On Sat, Aug 18, 2012 at 12:50 AM, Rouslan Placella <rouslan at placella.com>wrote:

> On 16/08/2012 21:56, Thilina Buddika Abeyrathna wrote:
> >
> >
> > On Fri, Aug 17, 2012 at 1:16 AM, Rouslan Placella <rouslan at placella.com
> > <mailto:rouslan at placella.com>> wrote:
> >
> >     On 16/08/2012 17:06, Thilina Buddika Abeyrathna wrote:
> >      >
> >      >
> >      > On Thu, Aug 16, 2012 at 2:57 AM, Thilina Buddika Abeyrathna
> >      > <thilinaabeyrathna at gmail.com <mailto:thilinaabeyrathna at gmail.com>
> >     <mailto:thilinaabeyrathna at gmail.com
> >     <mailto:thilinaabeyrathna at gmail.com>>> wrote:
> >      >
> >      >
> >      >
> >      >     On Thu, Aug 16, 2012 at 2:55 AM, Marc Delisle
> >     <marc at infomarc.info <mailto:marc at infomarc.info>
> >      >     <mailto:marc at infomarc.info <mailto:marc at infomarc.info>>>
> wrote:
> >      >
> >      >         Le 2012-08-15 16:24, Thilina Buddika Abeyrathna a écrit :
> >      >          > Hi Marc,
> >      >          > I'm looking [1] bug in the table  operation page,
> >      >          > I 'git checkout' to very old commit and check the same
> >     bug in
> >      >         there, But
> >      >          > still this bug was there,
> >      >          > I found that, first bad commit was
> >      >         4d2fcd910bc7e07114fcc76f55705c1a6e8c685e
> >      >          > (This is not a my commit)
> >      >          > I can't figure out where is this error happen.
> >      >          >
> >      >          > [1] -
> >      >          >
> >      >
> >
> http://sourceforge.net/tracker/?func=detail&aid=3555235&group_id=23067&atid=377408
> >      >
> >      >         Thilina,
> >      >         please use "git bisect" [2]  to find the problematic
> >     commits. I used
> >      >
> >      >         git bisect start HEAD QA_3_5
> >      >
> >      >         and found this:
> >      >
> >      >         a16e723048940f87b4be4b4097d16c4376826f2c is the first bad
> >     commit
> >      >         commit a16e723048940f87b4be4b4097d16c4376826f2c
> >      >         Author: Rouslan Placella <rouslan at placella.com
> >     <mailto:rouslan at placella.com>
> >      >         <mailto:rouslan at placella.com <mailto:rouslan at placella.com
> >>>
> >      >         Date:   Mon Jun 11 17:58:35 2012 +0100
> >      >
> >      >              Dropped PMA_ajaxResponse()
> >      >
> >      >         [2]
> >     http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
> >      >
> >      >
> >      >     Thank you Marc.
> >      >
> >      > Hi Rouslan,
> >      > Can you look at this error?
> >
> >     Problem #1 is already fixed in my branch [0], so I guess that you can
> >     ignore it.
> >
> >     Problem #2 has nothing to do with my code. Also keep in mind that the
> >     issue comes up when changing from innodb to myisam, but not the other
> >     way around. Here's the results of a bisect:
> >
> >     83401195710de736dc6217f885313b5dad9071ae is the first bad commit
> >     commit 83401195710de736dc6217f885313b5dad9071ae
> >     Author: Thilina Buddika <thilinaabeyrathna at gmail.com
> >     <mailto:thilinaabeyrathna at gmail.com>>
> >     Date:   Wed Aug 1 13:52:49 2012 +0530
> >
> >           further refactoring for PMA_getTableOptionFieldset()
> >
> >     :040000 040000 f7dba249f1ec47de37b26a2df7fc4562dd717b80
> >     7b7945eceffca79186916f9ed7e4e30f0d4cb0d7 M      libraries
> >
> >     Bye,
> >     Rouslan
> >
> >     [0]: https://github.com/roccivic/phpmyadmin/tree/frames-removal
> >
> > Problem 2# has been fixed.
> > Thanks  Rouslan.
>
> Hi Thilina,
>
> Same problem in copy table form:
>
> https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/operations.lib.php#L1036
>
> Could you please do a quick grep to see if there are more instances of
> the same elsewhere?
>

Thanks  Rouslan, I did the changes.

>
> Lastly, IMO, the ternary operator operator does no favours to us in
> terms of code readability there.
>
>

-- 
Regards.

Thilina Abeyrathna
Gtalk : thilinaabeyrathna
skype: thilinabuddika88
thilinaa.wordpress.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120818/a31d0056/attachment.html>