[Phpmyadmin-devel] Failing test

Michal Čihař michal at cihar.com
Tue Jul 10 10:08:47 CEST 2012


Hi

Dne Tue, 10 Jul 2012 13:28:29 +0530
Chanaka Dharmarathna <pe.chanaka.ck at gmail.com> napsal(a):

> The tests failures may because of my changes regarding introduce private
> properties.
> I were trying to fix those, but not fixed yet.

Well you're responsible for some of breakages, but definitely not
majority of them :-). Actually I was not about failing individual
tests, but rather on tests which can be run separately, but fail when
whole testsuite is being executed.

Many of the tests expect they will get a clean environment and rely on
some parameters not being set. This is not true when whole testsuite
runs as lot of code still relies on global variables. One of example
are parameters being added to URL. Possible fix is following:

https://github.com/phpmyadmin/phpmyadmin/commit/0f32f805d49166c2ba9f33323a54e338ce660e63

-- 
	Michal Čihař | http://cihar.com | http://phpmyadmin.cz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120710/fa897e19/attachment.sig>


More information about the Developers mailing list