[Phpmyadmin-devel] problem with ExportSql.class.php

[Atirek Goyal]

Hi Marc,

I think you mistakenly reply me this message I am not Alex. 
Please check..

Thanks,
Ati

-----Original Message-----
From: Marc Delisle [mailto:marc at infomarc.info] 
Sent: Thursday, July 26, 2012 6:39 PM
To: phpmyadmin-devel at lists.sf.net
Subject: [Phpmyadmin-devel] problem with ExportSql.class.php

Hi Alex,

I believe there is a problem with your implementation of getTableDef(). 
In the previous code, this function has the side effect of modifying 
several global variables, for example $sql_drop_foreign_keys.

In the new implementation, if I'm not mistaken, you are getting these 
global variables but never setting their modified values in the global 
space for use by the calling script.

I'm not advocating that you should continue using globals in this case, 
but we need a way to pass back these modified values, for example by 
passing back an array of results.

Please coordinate with Thilina who is refactoring db_operations.php.

-- 
Marc Delisle
http://infomarc.info

----------------------------------------------------------------------------
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel